Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing

Darrick J. Wong
2016-03-28T22:05:49Z

On Thu, Mar 10, 2016 at 06:19:13AM -0800, Christoph Hellwig wrote:
> On Tue, Mar 08, 2016 at 03:16:07PM +1100, Dave Chinner wrote:
> > From: "Darrick J. Wong" <darrick.wong@oracle.com>
> >
> > For the rmap btree to work, we have to fed the extent owner
>
> s/fed/feed/

<nod>

>
> > +/*
> > + * Ownership info for an extent. This is used to create reverse-mapping
> > + * entries.
> > + */
> > +#define XFS_RMAP_INO_ATTR_FORK (1)
> > +#define XFS_RMAP_BMBT_BLOCK (2)
>
> These are OR-able flags - it might make sense to define them as:
>
> #define XFS_RMAP_INO_ATTR_FORK (1 << 0)
> #define XFS_RMAP_BMBT_BLOCK (1 << 1)
>
> to make this more obvious.

Ok. Will do when I merge the "separate xfs_rmap_irec flags field" patch
into the appropriate patches (like this one).

--D

>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs