Re: [PATCH v23 12/22] vfs: Add get_richacl and set_richacl inode operations

Jeff Layton
2016-07-06T18:31:22Z

On Thu, 2016-06-30 at 15:47 +0200, Andreas Gruenbacher wrote:
> These operations are similar to the get_acl and set_acl operations for
> POSIX ACLs.  The distinction between access and default ACLs doesn't exist
> for richacls.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> Reviewed-by: Steve French <steve.french@primarydata.com>
> ---
>  include/linux/fs.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 06a30b0..ac96bda 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -1726,6 +1726,7 @@ struct inode_operations {
>   const char * (*get_link) (struct dentry *, struct inode *, struct delayed_call *);
>   int (*permission) (struct inode *, int);
>   struct posix_acl * (*get_acl)(struct inode *, int);
> + struct richacl * (*get_richacl)(struct inode *);
>
>   int (*readlink) (struct dentry *, char __user *,int);
>
> @@ -1756,6 +1757,7 @@ struct inode_operations {
>      umode_t create_mode, int *opened);
>   int (*tmpfile) (struct inode *, struct dentry *, umode_t);
>   int (*set_acl)(struct inode *, struct posix_acl *, int);
> + int (*set_richacl)(struct inode *, struct richacl *);
>  } ____cacheline_aligned;
>
>  ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector,

Looks OK, though it's hard to review something like this without some
context. Maybe this patch should be folded in with the patch that
actually adds the calls for these operations?

Reviewed-by: Jeff Layton <jlayton@redhat.com>