* [PATCH] xfs/279: filter scsi debug device correctly
@ 2016-09-05 5:30 Eryu Guan
2016-09-07 22:47 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Eryu Guan @ 2016-09-05 5:30 UTC (permalink / raw)
To: fstests; +Cc: linux-xfs, Eryu Guan, xfs
This test assumes scsi debug device is "/dev/sd." when doing the
filter, but that isn't always true, I've seen failure like
-mkfs with opts: DEVICE
+mkfs with opts: DEVICEl
So use $SCSI_DEBUG_DEV to match the correct scsi debug device name.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
tests/xfs/279 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/279 b/tests/xfs/279
index cde7d21..9dee4cf 100755
--- a/tests/xfs/279
+++ b/tests/xfs/279
@@ -61,7 +61,7 @@ _wipe_device()
_check_mkfs()
{
echo "==================="
- echo "mkfs with opts: $@" | sed -e "s,/dev/sd.,DEVICE,"
+ echo "mkfs with opts: $@" | sed -e "s,$SCSI_DEBUG_DEV,DEVICE,"
$MKFS_XFS_PROG $@ 2>/dev/null > $tmp.mkfs.full
if [ $? -ne 0 ]; then
echo "Failed."
--
2.7.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs/279: filter scsi debug device correctly
2016-09-05 5:30 [PATCH] xfs/279: filter scsi debug device correctly Eryu Guan
@ 2016-09-07 22:47 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2016-09-07 22:47 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests, xfs, linux-xfs
On Mon, Sep 05, 2016 at 01:30:27PM +0800, Eryu Guan wrote:
> This test assumes scsi debug device is "/dev/sd." when doing the
> filter, but that isn't always true, I've seen failure like
>
> -mkfs with opts: DEVICE
> +mkfs with opts: DEVICEl
Yeah, I can see how that would occur when you have enough scsi
devices to go to multiple device characters (e.g. /dev/sdal).
> So use $SCSI_DEBUG_DEV to match the correct scsi debug device name.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-07 22:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-05 5:30 [PATCH] xfs/279: filter scsi debug device correctly Eryu Guan
2016-09-07 22:47 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).