From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:49271 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756784AbcJGVJS (ORCPT ); Fri, 7 Oct 2016 17:09:18 -0400 From: Ross Zwisler Subject: [PATCH v5 05/17] ext2: return -EIO on ext2_iomap_end() failure Date: Fri, 7 Oct 2016 15:08:52 -0600 Message-Id: <1475874544-24842-6-git-send-email-ross.zwisler@linux.intel.com> In-Reply-To: <1475874544-24842-1-git-send-email-ross.zwisler@linux.intel.com> References: <1475874544-24842-1-git-send-email-ross.zwisler@linux.intel.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: linux-kernel@vger.kernel.org Cc: Ross Zwisler , Theodore Ts'o , Alexander Viro , Andreas Dilger , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Matthew Wilcox , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org Right now we just return 0 for success, but we really want to let callers know about this failure. Signed-off-by: Ross Zwisler --- fs/ext2/inode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index c7dbb46..368913c 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -830,8 +830,10 @@ ext2_iomap_end(struct inode *inode, loff_t offset, loff_t length, { if (iomap->type == IOMAP_MAPPED && written < length && - (flags & IOMAP_WRITE)) + (flags & IOMAP_WRITE)) { ext2_write_failed(inode->i_mapping, offset + length); + return -EIO; + } return 0; } -- 2.7.4