* [PATCH] xfs/122: remove dead code
@ 2016-10-08 8:53 Eryu Guan
2016-10-08 17:45 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Eryu Guan @ 2016-10-08 8:53 UTC (permalink / raw)
To: fstests; +Cc: linux-xfs, Eryu Guan
Seems this hunk of dead code is used for debug purpose to inspect
what the output looks like after _attribute_filter. Just remove it.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
tests/xfs/122 | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tests/xfs/122 b/tests/xfs/122
index 330d3ac..f39ceba 100755
--- a/tests/xfs/122
+++ b/tests/xfs/122
@@ -196,10 +196,6 @@ echo 'int main(int argc, char *argv[]) {' >>$cprog
#
cat /usr/include/xfs/xfs*.h | indent |\
_attribute_filter |\
-egrep '(} *xfs_.*_t|^struct xfs_[a-z0-9_]*$)' > /tmp/barf
-
-cat /usr/include/xfs/xfs*.h | indent |\
-_attribute_filter |\
egrep '(} *xfs_.*_t|^struct xfs_[a-z0-9_]*$)' |\
egrep -v -f $tmp.ignore |\
sed -e 's/^.*}[[:space:]]*//g' -e 's/;.*$//g' -e 's/_t, /_t\n/g' |\
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs/122: remove dead code
2016-10-08 8:53 [PATCH] xfs/122: remove dead code Eryu Guan
@ 2016-10-08 17:45 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2016-10-08 17:45 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests, linux-xfs
On Sat, Oct 08, 2016 at 04:53:56PM +0800, Eryu Guan wrote:
> Seems this hunk of dead code is used for debug purpose to inspect
> what the output looks like after _attribute_filter. Just remove it.
Heh. Barf. Ooops. :)
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> tests/xfs/122 | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/tests/xfs/122 b/tests/xfs/122
> index 330d3ac..f39ceba 100755
> --- a/tests/xfs/122
> +++ b/tests/xfs/122
> @@ -196,10 +196,6 @@ echo 'int main(int argc, char *argv[]) {' >>$cprog
> #
> cat /usr/include/xfs/xfs*.h | indent |\
> _attribute_filter |\
> -egrep '(} *xfs_.*_t|^struct xfs_[a-z0-9_]*$)' > /tmp/barf
> -
> -cat /usr/include/xfs/xfs*.h | indent |\
> -_attribute_filter |\
> egrep '(} *xfs_.*_t|^struct xfs_[a-z0-9_]*$)' |\
> egrep -v -f $tmp.ignore |\
> sed -e 's/^.*}[[:space:]]*//g' -e 's/;.*$//g' -e 's/_t, /_t\n/g' |\
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-08 17:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-08 8:53 [PATCH] xfs/122: remove dead code Eryu Guan
2016-10-08 17:45 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).