linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Theodore Ts'o <tytso@mit.edu>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@lst.de>,
	Dan Williams <dan.j.williams@intel.com>,
	Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>,
	Matthew Wilcox <mawilcox@microsoft.com>,
	linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, linux-nvdimm@lists.01.org,
	linux-xfs@vger.kernel.org
Subject: [PATCH v8 01/16] ext4: tell DAX the size of allocation holes
Date: Wed, 19 Oct 2016 13:34:20 -0600	[thread overview]
Message-ID: <1476905675-32581-2-git-send-email-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <1476905675-32581-1-git-send-email-ross.zwisler@linux.intel.com>

When DAX calls _ext4_get_block() and the file offset points to a hole we
currently don't set bh->b_size.  This is current worked around via
buffer_size_valid() in fs/dax.c.

_ext4_get_block() has the hole size information from ext4_map_blocks(), so
populate bh->b_size so we can remove buffer_size_valid() in a later patch.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 fs/ext4/inode.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 9c06472..3d58b2b 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -767,6 +767,9 @@ static int _ext4_get_block(struct inode *inode, sector_t iblock,
 		ext4_update_bh_state(bh, map.m_flags);
 		bh->b_size = inode->i_sb->s_blocksize * map.m_len;
 		ret = 0;
+	} else if (ret == 0) {
+		/* hole case, need to fill in bh->b_size */
+		bh->b_size = inode->i_sb->s_blocksize * map.m_len;
 	}
 	return ret;
 }
-- 
2.7.4


  reply	other threads:[~2016-10-19 19:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19 19:34 [PATCH v8 00/16] re-enable DAX PMD support Ross Zwisler
2016-10-19 19:34 ` Ross Zwisler [this message]
2016-10-19 19:34 ` [PATCH v8 02/16] dax: remove buffer_size_valid() Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 03/16] ext2: remove support for DAX PMD faults Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 04/16] dax: make 'wait_table' global variable static Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 05/16] dax: remove the last BUG_ON() from fs/dax.c Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 06/16] dax: consistent variable naming for DAX entries Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 07/16] dax: coordinate locking for offsets in PMD range Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 08/16] dax: remove dax_pmd_fault() Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 09/16] dax: correct dax iomap code namespace Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 10/16] dax: add dax_iomap_sector() helper function Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 11/16] dax: dax_iomap_fault() needs to call iomap_end() Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 12/16] dax: move RADIX_DAX_* defines to dax.h Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 13/16] dax: move put_(un)locked_mapping_entry() in dax.c Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 14/16] dax: add struct iomap based DAX PMD support Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 15/16] xfs: use struct iomap based DAX PMD fault path Ross Zwisler
2016-10-19 19:34 ` [PATCH v8 16/16] dax: remove "depends on BROKEN" from FS_DAX_PMD Ross Zwisler
2016-10-27 14:41 ` [PATCH v8 00/16] re-enable DAX PMD support Ross Zwisler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476905675-32581-2-git-send-email-ross.zwisler@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mawilcox@microsoft.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).