linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 0/3] xfs: a few reflink cowblocks fixes
Date: Fri, 21 Oct 2016 13:22:10 -0400	[thread overview]
Message-ID: <1477070533-59327-1-git-send-email-bfoster@redhat.com> (raw)

This is just a few reflink fixes associated with cowblocks tagging that
I came across when playing around with and/or reviewing some code. The
issue associated with patch 3 is easily reproducible with something like
the following:

	echo 30 > /proc/sys/fs/xfs/speculative_cow_prealloc_lifetime

	xfs_io -fc "cowextsize 64k" $src
	xfs_io -c "pwrite 0 128k" $src
	cp --reflink $src $tgt

	xfs_io -c "pwrite 64k 32k" $tgt
	xfs_io -c "pwrite 96k 32k" $tgt
	echo sleep
	sleep 25
	echo delalloc
	xfs_io -c "pwrite 0 4k" $tgt

... which basically just sets the cowblocks tag, uses up all of the
resulting cow blocks, waits until just before the cowblocks scanner is
going to run and creates a delalloc reservation in the cow fork. The cow
fork fiemap thingy I sent the other day shows that the resulting cow
fork blocks remain indefinitely.

Thoughts, reviews, flames appreciated.

Brian

Brian Foster (3):
  xfs: fix up inode cowblocks tracking tracepoints
  xfs: clear cowblocks tag when cow fork is emptied
  xfs: don't skip cow forks w/ delalloc blocks in cowblocks scan

 fs/xfs/xfs_icache.c  | 10 +++++-----
 fs/xfs/xfs_reflink.c | 29 +++++++++--------------------
 fs/xfs/xfs_reflink.h |  2 +-
 3 files changed, 15 insertions(+), 26 deletions(-)

-- 
2.7.4


             reply	other threads:[~2016-10-21 17:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21 17:22 Brian Foster [this message]
2016-10-21 17:22 ` [PATCH 1/3] xfs: fix up inode cowblocks tracking tracepoints Brian Foster
2016-10-22  0:52   ` Darrick J. Wong
2016-10-22  8:46   ` Christoph Hellwig
2016-10-21 17:22 ` [PATCH 2/3] xfs: clear cowblocks tag when cow fork is emptied Brian Foster
2016-10-22  0:58   ` Darrick J. Wong
2016-10-22  8:47   ` Christoph Hellwig
2016-10-21 17:22 ` [PATCH 3/3] xfs: don't skip cow forks w/ delalloc blocks in cowblocks scan Brian Foster
2016-10-22  8:49   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477070533-59327-1-git-send-email-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).