linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Theodore Ts'o <tytso@mit.edu>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@lst.de>,
	Dan Williams <dan.j.williams@intel.com>,
	Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>,
	Matthew Wilcox <mawilcox@microsoft.com>,
	linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, linux-nvdimm@lists.01.org,
	linux-xfs@vger.kernel.org
Subject: [PATCH v9 10/16] dax: add dax_iomap_sector() helper function
Date: Tue,  1 Nov 2016 13:54:12 -0600	[thread overview]
Message-ID: <1478030058-1422-11-git-send-email-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <1478030058-1422-1-git-send-email-ross.zwisler@linux.intel.com>

To be able to correctly calculate the sector from a file position and a
struct iomap there is a complex little bit of logic that currently happens
in both dax_iomap_actor() and dax_iomap_fault().  This will need to be
repeated yet again in the DAX PMD fault handler when it is added, so break
it out into a helper function.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 fs/dax.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/fs/dax.c b/fs/dax.c
index fdbd7a1..7737954 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -1030,6 +1030,11 @@ int dax_truncate_page(struct inode *inode, loff_t from, get_block_t get_block)
 EXPORT_SYMBOL_GPL(dax_truncate_page);
 
 #ifdef CONFIG_FS_IOMAP
+static sector_t dax_iomap_sector(struct iomap *iomap, loff_t pos)
+{
+	return iomap->blkno + (((pos & PAGE_MASK) - iomap->offset) >> 9);
+}
+
 static loff_t
 dax_iomap_actor(struct inode *inode, loff_t pos, loff_t length, void *data,
 		struct iomap *iomap)
@@ -1055,8 +1060,7 @@ dax_iomap_actor(struct inode *inode, loff_t pos, loff_t length, void *data,
 		struct blk_dax_ctl dax = { 0 };
 		ssize_t map_len;
 
-		dax.sector = iomap->blkno +
-			(((pos & PAGE_MASK) - iomap->offset) >> 9);
+		dax.sector = dax_iomap_sector(iomap, pos);
 		dax.size = (length + offset + PAGE_SIZE - 1) & PAGE_MASK;
 		map_len = dax_map_atomic(iomap->bdev, &dax);
 		if (map_len < 0) {
@@ -1193,7 +1197,7 @@ int dax_iomap_fault(struct vm_area_struct *vma, struct vm_fault *vmf,
 		goto unlock_entry;
 	}
 
-	sector = iomap.blkno + (((pos & PAGE_MASK) - iomap.offset) >> 9);
+	sector = dax_iomap_sector(&iomap, pos);
 
 	if (vmf->cow_page) {
 		switch (iomap.type) {
-- 
2.7.4


  parent reply	other threads:[~2016-11-01 19:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-01 19:54 [PATCH v9 00/16] re-enable DAX PMD support Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 01/16] ext4: tell DAX the size of allocation holes Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 02/16] dax: remove buffer_size_valid() Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 03/16] ext2: remove support for DAX PMD faults Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 04/16] dax: make 'wait_table' global variable static Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 05/16] dax: remove the last BUG_ON() from fs/dax.c Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 06/16] dax: consistent variable naming for DAX entries Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 07/16] dax: coordinate locking for offsets in PMD range Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 08/16] dax: remove dax_pmd_fault() Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 09/16] dax: correct dax iomap code namespace Ross Zwisler
2016-11-01 19:54 ` Ross Zwisler [this message]
2016-11-01 19:54 ` [PATCH v9 11/16] dax: dax_iomap_fault() needs to call iomap_end() Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 12/16] dax: move RADIX_DAX_* defines to dax.h Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 13/16] dax: move put_(un)locked_mapping_entry() in dax.c Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 14/16] dax: add struct iomap based DAX PMD support Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 15/16] xfs: use struct iomap based DAX PMD fault path Ross Zwisler
2016-11-01 19:54 ` [PATCH v9 16/16] dax: remove "depends on BROKEN" from FS_DAX_PMD Ross Zwisler
2016-11-03  1:58 ` [PATCH v9 00/16] re-enable DAX PMD support Dave Chinner
2016-11-03 17:51   ` Ross Zwisler
2016-11-03 21:16     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478030058-1422-11-git-send-email-ross.zwisler@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mawilcox@microsoft.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).