From: Christoph Hellwig <hch@lst.de>
To: linux-xfs@vger.kernel.org
Cc: darrick.wong@oracle.com
Subject: reflink COW improvements
Date: Mon, 5 Dec 2016 22:05:21 +0100 [thread overview]
Message-ID: <1480971924-4864-1-git-send-email-hch@lst.de> (raw)
Hi all,
this series adds a few improvements to the direct I/O COW path.
Note that patch 2 at this point causes a regression in xfs/214:
@ -11,7 +11,7 @@
CoW one of the files
root -- 0 0 0 4 0 0
nobody -- 0 0 0 1 0 0
-fsgqa -- 3520 0 0 4 0 0
+fsgqa -- 3072 0 0 4 0 0
Remount the FS to see if accounting changes
root -- 0 0 0 4 0 0
nobody -- 0 0 0 1 0 0
But I think the test golden output actually is wrong - the test
claims it tests that we don't get blocks charged during the COW,
but the 3520 here means 512 bytes were charged, and later in the
golden output we actually see that going away after a remount.
next reply other threads:[~2016-12-05 21:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 21:05 Christoph Hellwig [this message]
2016-12-05 21:05 ` [PATCH 1/3] xfs: reject all unaligned direct writes to reflinked files Christoph Hellwig
2016-12-07 18:59 ` Brian Foster
2016-12-05 21:05 ` [PATCH 2/3] xfs: go straight to real allocations for direct I/O COW writes Christoph Hellwig
2016-12-07 19:00 ` Brian Foster
2016-12-07 19:37 ` Christoph Hellwig
2016-12-07 19:46 ` Brian Foster
2016-12-08 4:23 ` Darrick J. Wong
2017-01-24 8:37 ` Christoph Hellwig
2017-01-24 13:50 ` Brian Foster
2017-01-24 13:59 ` Christoph Hellwig
2017-01-24 15:02 ` Brian Foster
2017-01-24 15:09 ` Christoph Hellwig
2017-01-24 16:17 ` Brian Foster
2017-01-24 16:21 ` Christoph Hellwig
2017-01-24 17:43 ` Brian Foster
2017-01-24 20:08 ` Christoph Hellwig
2017-01-24 20:10 ` Christoph Hellwig
2017-01-25 0:09 ` Darrick J. Wong
2017-01-27 17:44 ` Darrick J. Wong
2017-01-27 17:48 ` Christoph Hellwig
2016-12-05 21:05 ` [PATCH 3/3] xfs: allocate direct I/O COW blocks in iomap_begin Christoph Hellwig
2016-12-06 2:09 ` reflink COW improvements Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480971924-4864-1-git-send-email-hch@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).