From: Jan Tulak <jtulak@redhat.com>
To: linux-xfs@vger.kernel.org
Cc: Jan Tulak <jtulak@redhat.com>
Subject: [PATCH 07/22] mkfs: Move opts related #define to one place
Date: Wed, 7 Dec 2016 14:27:14 +0100 [thread overview]
Message-ID: <1481117249-21273-8-git-send-email-jtulak@redhat.com> (raw)
In-Reply-To: <1481117249-21273-1-git-send-email-jtulak@redhat.com>
Takes all the "#define M_CRC x" from struct opt_params declaration and moves
them into a single place before the struct. This is because we need to
cross-link conflicts and we can't link -l version to -m crc if M_CRC is defined
after the conflict section.
Signed-off-by: Jan Tulak <jtulak@redhat.com>
---
mkfs/xfs_mkfs.c | 138 ++++++++++++++++++++++++++++++--------------------------
1 file changed, 74 insertions(+), 64 deletions(-)
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index e46b55c..2122d1c 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -48,6 +48,80 @@ unsigned int sectorsize;
#define MAX_CONFLICTS 8
#define LAST_CONFLICT (-1)
+#define OPT_B 0
+#define B_LOG 0
+#define B_SIZE 1
+
+#define OPT_D 1
+#define D_AGCOUNT 0
+#define D_FILE 1
+#define D_NAME 2
+#define D_SIZE 3
+#define D_SUNIT 4
+#define D_SWIDTH 5
+#define D_AGSIZE 6
+#define D_SU 7
+#define D_SW 8
+#define D_SECTLOG 9
+#define D_SECTSIZE 10
+#define D_NOALIGN 11
+#define D_RTINHERIT 12
+#define D_PROJINHERIT 13
+#define D_EXTSZINHERIT 14
+
+
+#define OPT_I 2
+#define I_ALIGN 0
+#define I_LOG 1
+#define I_MAXPCT 2
+#define I_PERBLOCK 3
+#define I_SIZE 4
+#define I_ATTR 5
+#define I_PROJID32BIT 6
+#define I_SPINODES 7
+
+#define OPT_L 3
+#define L_AGNUM 0
+#define L_INTERNAL 1
+#define L_SIZE 2
+#define L_VERSION 3
+#define L_SUNIT 4
+#define L_SU 5
+#define L_DEV 6
+#define L_SECTLOG 7
+#define L_SECTSIZE 8
+#define L_FILE 9
+#define L_NAME 10
+#define L_LAZYSBCNTR 11
+
+
+#define OPT_N 4
+#define N_LOG 0
+#define N_SIZE 1
+#define N_VERSION 2
+#define N_FTYPE 3
+
+#define OPT_R 5
+#define R_EXTSIZE 0
+#define R_SIZE 1
+#define R_DEV 2
+#define R_FILE 3
+#define R_NAME 4
+#define R_NOALIGN 5
+
+#define OPT_S 6
+#define S_LOG 0
+#define S_SECTLOG 1
+#define S_SIZE 2
+#define S_SECTSIZE 3
+
+#define OPT_M 7
+#define M_CRC 0
+#define M_FINOBT 1
+#define M_UUID 2
+#define M_RMAPBT 3
+#define M_REFLINK 4
+
/*
* Table for parsing mkfs parameters.
*
@@ -155,14 +229,11 @@ struct opt_params {
long long value;
} subopt_params[MAX_SUBOPTS];
} opts[MAX_OPTS] = {
-#define OPT_B 0
{
.index = OPT_B,
.name = 'b',
.subopts = {
-#define B_LOG 0
"log",
-#define B_SIZE 1
"size",
NULL
},
@@ -185,40 +256,24 @@ struct opt_params {
},
},
},
-#define OPT_D 1
{
.index = OPT_D,
.name = 'd',
.subopts = {
- #define D_AGCOUNT 0
"agcount",
- #define D_FILE 1
"file",
- #define D_NAME 2
"name",
- #define D_SIZE 3
"size",
- #define D_SUNIT 4
"sunit",
- #define D_SWIDTH 5
"swidth",
- #define D_AGSIZE 6
"agsize",
- #define D_SU 7
"su",
- #define D_SW 8
"sw",
- #define D_SECTLOG 9
"sectlog",
- #define D_SECTSIZE 10
"sectsize",
- #define D_NOALIGN 11
"noalign",
- #define D_RTINHERIT 12
"rtinherit",
- #define D_PROJINHERIT 13
"projinherit",
- #define D_EXTSZINHERIT 14
"extszinherit",
NULL
},
@@ -338,26 +393,17 @@ struct opt_params {
},
},
},
-#define OPT_I 2
{
.index = OPT_I,
.name = 'i',
.subopts = {
-#define I_ALIGN 0
"align",
-#define I_LOG 1
"log",
-#define I_MAXPCT 2
"maxpct",
-#define I_PERBLOCK 3
"perblock",
-#define I_SIZE 4
"size",
-#define I_ATTR 5
"attr",
-#define I_PROJID32BIT 6
"projid32bit",
-#define I_SPINODES 7
"sparse",
NULL
},
@@ -420,34 +466,21 @@ struct opt_params {
},
},
},
-#define OPT_L 3
{
.index = OPT_L,
.name = 'l',
.subopts = {
- #define L_AGNUM 0
"agnum",
- #define L_INTERNAL 1
"internal",
- #define L_SIZE 2
"size",
- #define L_VERSION 3
"version",
- #define L_SUNIT 4
"sunit",
- #define L_SU 5
"su",
- #define L_DEV 6
"logdev",
- #define L_SECTLOG 7
"sectlog",
- #define L_SECTSIZE 8
"sectsize",
- #define L_FILE 9
"file",
- #define L_NAME 10
"name",
- #define L_LAZYSBCNTR 11
"lazy-count",
NULL
},
@@ -538,18 +571,13 @@ struct opt_params {
},
},
},
-#define OPT_N 4
{
.index = OPT_N,
.name = 'n',
.subopts = {
- #define N_LOG 0
"log",
- #define N_SIZE 1
"size",
- #define N_VERSION 2
"version",
- #define N_FTYPE 3
"ftype",
NULL,
},
@@ -584,22 +612,15 @@ struct opt_params {
},
},
},
-#define OPT_R 5
{
.index = OPT_R,
.name = 'r',
.subopts = {
- #define R_EXTSIZE 0
"extsize",
- #define R_SIZE 1
"size",
- #define R_DEV 2
"rtdev",
- #define R_FILE 3
"file",
- #define R_NAME 4
"name",
- #define R_NOALIGN 5
"noalign",
NULL
},
@@ -640,18 +661,13 @@ struct opt_params {
},
},
},
-#define OPT_S 6
{
.index = OPT_S,
.name = 's',
.subopts = {
- #define S_LOG 0
"log",
- #define S_SECTLOG 1
"sectlog",
- #define S_SIZE 2
"size",
- #define S_SECTSIZE 3
"sectsize",
NULL
},
@@ -694,20 +710,14 @@ struct opt_params {
},
},
},
-#define OPT_M 7
{
.index = OPT_M,
.name = 'm',
.subopts = {
- #define M_CRC 0
"crc",
- #define M_FINOBT 1
"finobt",
- #define M_UUID 2
"uuid",
- #define M_RMAPBT 3
"rmapbt",
- #define M_REFLINK 4
"reflink",
NULL
},
--
2.8.1
next prev parent reply other threads:[~2016-12-07 13:34 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 13:27 [RFC PATCH 00/22] mkfs.xfs: Make stronger conflict checks Jan Tulak
2016-12-07 13:27 ` [PATCH 01/22] mkfs: remove intermediate getstr followed by getnum Jan Tulak
2017-01-13 16:56 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 02/22] mkfs: merge tables for opts parsing into one table Jan Tulak
2017-01-13 16:57 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 03/22] mkfs: extend opt_params with a value field Jan Tulak
2017-01-13 16:55 ` Bill O'Donnell
2017-01-16 12:42 ` Jan Tulak
2016-12-07 13:27 ` [PATCH 04/22] mkfs: change conflicts array into a table capable of cross-option addressing Jan Tulak
2017-01-13 17:56 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 05/22] mkfs: add a check for conflicting values Jan Tulak
2017-01-13 17:58 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 06/22] mkfs: add cross-section conflict checks Jan Tulak
2017-01-13 21:18 ` Bill O'Donnell
2016-12-07 13:27 ` Jan Tulak [this message]
2017-01-13 21:19 ` [PATCH 07/22] mkfs: Move opts related #define to one place Bill O'Donnell
2016-12-07 13:27 ` [PATCH 08/22] mkfs: move conflicts into the table Jan Tulak
2017-01-13 21:20 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 09/22] mkfs: change conflict checks to utilize the new conflict structure Jan Tulak
2017-01-13 17:08 ` Bill O'Donnell
2017-01-16 12:42 ` Jan Tulak
2016-12-07 13:27 ` [PATCH 10/22] mkfs: change when to mark an option as seen Jan Tulak
2017-01-13 21:20 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 11/22] mkfs: add test_default_value into conflict struct Jan Tulak
2017-01-13 21:21 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 12/22] mkfs: expand conflicts declarations to named declaration Jan Tulak
2017-01-13 17:21 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 13/22] mkfs: remove zeroed items from conflicts declaration Jan Tulak
2017-01-16 14:13 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 14/22] mkfs: rename defaultval to flagval in opts Jan Tulak
2017-01-16 14:14 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 15/22] mkfs: replace SUBOPT_NEEDS_VAL for a flag Jan Tulak
2017-01-16 14:14 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 16/22] mkfs: Change all value fields in opt structures into unions Jan Tulak
2017-01-13 17:36 ` Bill O'Donnell
2017-01-16 12:44 ` Jan Tulak
2016-12-07 13:27 ` [PATCH 17/22] mkfs: use old variables as pointers to the new opts struct values Jan Tulak
2017-01-13 17:43 ` Bill O'Donnell
2017-01-16 12:45 ` Jan Tulak
2016-12-07 13:27 ` [PATCH 18/22] mkfs: prevent sector/blocksize to be specified as a number of blocks Jan Tulak
2017-01-16 14:15 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 19/22] mkfs: subopt flags should be saved as bool Jan Tulak
2017-01-16 14:16 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 20/22] mkfs: move uuid empty string test to getstr() Jan Tulak
2017-01-16 14:16 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 21/22] mkfs: remove duplicit checks Jan Tulak
2017-01-16 14:17 ` Bill O'Donnell
2016-12-07 13:27 ` [PATCH 22/22] mkfs: prevent multiple specifications of a single option Jan Tulak
2017-01-16 14:18 ` Bill O'Donnell
2017-01-06 11:42 ` [RFC PATCH 00/22] mkfs.xfs: Make stronger conflict checks Jan Tulak
2017-01-09 19:43 ` Eric Sandeen
2017-01-10 9:47 ` Jan Tulak
2017-01-12 15:46 ` Bill O'Donnell
2017-01-16 20:14 ` Bill O'Donnell
-- strict thread matches above, loose matches on Subject: below --
2017-03-15 15:59 [PATCH " Jan Tulak
2017-03-15 16:00 ` [PATCH 07/22] mkfs: Move opts related #define to one place Jan Tulak
2017-03-16 23:25 ` Luis R. Rodriguez
2017-03-17 12:11 ` Jan Tulak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481117249-21273-8-git-send-email-jtulak@redhat.com \
--to=jtulak@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).