linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Brian Foster <bfoster@redhat.com>,
	"Darrick J . Wong" <darrick.wong@oracle.com>,
	fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH v3 0/3] xfs: test malformed inode mode
Date: Mon,  9 Jan 2017 15:30:22 +0200	[thread overview]
Message-ID: <1483968625-29160-1-git-send-email-amir73il@gmail.com> (raw)

Eryu,

This is the 3rd revision of the malformed inode mode test.

Like with v2, patch 1 is safe and it passes on kernel 4.9.

Like with v2, patch 2 is safe, but unlike v2, it fails on
kernel 4.9, because I added a stronger expectation for the
test to fails on stat of directory with inode size 0.

Like with v2, patch 3 triggers an XFS assert and I removed
the "safety pin" that was there in v2.

I already sent the fix patch to Darick, which addresses the
failures in both patch 2 and 3.

You could merge patch 1 now and defer merging patches 2-3
or you could wait with merging the entire test. up to you.

Amir.

v3:
- added empty and non empty regular file cases (patch 1)
- expect to detect directory with size 0 as an error (patch 2)
- removed the "safety pin" from patch 3

v2:
- test fstat with malformed inode mode
- test readlink/readdir with malformed inode mode

v1:
- test xfs_repair with malformed inode mode


Amir Goldstein (3):
  xfs: test handling of invalid inode modes
  xfs: test fstat with malformed inode mode
  xfs: test readlink/readdir with malformed inode mode

 tests/xfs/348     | 154 +++++++++++++++++++++++
 tests/xfs/348.out | 360 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/xfs/group   |   1 +
 3 files changed, 515 insertions(+)
 create mode 100755 tests/xfs/348
 create mode 100644 tests/xfs/348.out

-- 
2.7.4


             reply	other threads:[~2017-01-09 13:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 13:30 Amir Goldstein [this message]
2017-01-09 13:30 ` [PATCH v3 1/3] xfs: test handling of invalid inode modes Amir Goldstein
2017-01-09 13:36   ` Amir Goldstein
2017-01-09 13:39   ` Amir Goldstein
2017-01-09 13:30 ` [PATCH v3 2/3] xfs: test fstat with malformed inode mode Amir Goldstein
2017-01-09 13:30 ` [PATCH v3 3/3] xfs: test readlink/readdir " Amir Goldstein
2017-01-11  6:38   ` Amir Goldstein
2017-01-11  6:41   ` Amir Goldstein
2017-01-20  5:25 ` [PATCH v3 0/3] xfs: test " Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483968625-29160-1-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=bfoster@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).