From: Amir Goldstein <amir73il@gmail.com>
To: "Darrick J . Wong" <darrick.wong@oracle.com>
Cc: Brian Foster <bfoster@redhat.com>, Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org
Subject: [PATCH v8 0/6] xfs: fixes for malformed on-disk i_mode
Date: Wed, 11 Jan 2017 10:24:04 +0200 [thread overview]
Message-ID: <1484123050-11064-1-git-send-email-amir73il@gmail.com> (raw)
Darrick,
This is 8th revision of the fixes for malformed on-disk i_mode.
Patches 1-2 are reviewed by Christoph and IMO, you should consider
patch 1 and perhaprs also patch 2 for 4.10 and stable 4.9.
Patches 4-6 replace xfs_mode_to_ftype table with switch statement
per Christoph's suggestion and add sanity checks.
Tested with generic/401 with -n ftype=0|1.
Tested with new xfs/348 test with -n ftype=0|1.
Amir.
v8:
- Address review comments by Darrick
- Added Reviewed-by Darrick to patches 4,6
v7:
- Replaced xfs_mode_to_ftype table with switch statement
- Reordered patches so reviewed trivial patches are first
- Added Reviewed-by Christoph to first 2 patches
- Added cleanup patch for xfs_dir2.h
- Added sanity checks for invalid mode in more places
v6:
- Added Reviewed-by Brian for patch 1
- Added patch to address new xfs/348 failures
- Added patch to fix ASSERT() likely
v5:
- remove wrong argument about on-disk malformed mode from commit message
- address Brian's review comments
v4:
- independent fix patch for xfs
*** BLURB HERE ***
Amir Goldstein (6):
xfs: make the ASSERT() condition likely
xfs: sanity check directory inode di_size
xfs: add missing include dependencies to xfs_dir2.h
xfs: replace xfs_mode_to_ftype table with switch statement
xfs: sanity check inode mode when creating new dentry
xfs: sanity check inode di_mode
fs/xfs/libxfs/xfs_dir2.c | 39 ++++++++++++++++++++-------------
fs/xfs/libxfs/xfs_dir2.h | 8 ++++---
fs/xfs/libxfs/xfs_inode_buf.c | 10 +++++++--
fs/xfs/xfs_iops.c | 50 ++++++++++++++++++++++++++++++++++---------
fs/xfs/xfs_linux.h | 6 +++---
5 files changed, 80 insertions(+), 33 deletions(-)
--
2.7.4
next reply other threads:[~2017-01-11 8:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 8:24 Amir Goldstein [this message]
2017-01-11 8:24 ` [PATCH v8 1/6] xfs: make the ASSERT() condition likely Amir Goldstein
2017-01-13 7:25 ` Christoph Hellwig
2017-01-18 20:57 ` Darrick J. Wong
2017-01-11 8:24 ` [PATCH v8 2/6] xfs: sanity check directory inode di_size Amir Goldstein
2017-01-14 6:28 ` Darrick J. Wong
2017-01-11 8:24 ` [PATCH v8 3/6] xfs: add missing include dependencies to xfs_dir2.h Amir Goldstein
2017-01-11 8:38 ` Christoph Hellwig
2017-01-11 8:24 ` [PATCH v8 4/6] xfs: replace xfs_mode_to_ftype table with switch statement Amir Goldstein
2017-01-11 8:38 ` Christoph Hellwig
2017-01-11 8:24 ` [PATCH v8 5/6] xfs: sanity check inode mode when creating new dentry Amir Goldstein
2017-01-11 8:42 ` Christoph Hellwig
2017-01-11 8:24 ` [PATCH v8 6/6] xfs: sanity check inode di_mode Amir Goldstein
2017-01-11 8:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484123050-11064-1-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).