linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jeffm@suse.com
To: linux-xfs@vger.kernel.org
Cc: Jeff Mahoney <jeffm@suse.com>
Subject: [PATCH 0/3] xfs_repair: pthread creation failure recovery fixes
Date: Mon, 16 Jan 2017 23:39:30 -0500	[thread overview]
Message-ID: <1484627973-11535-1-git-send-email-jeffm@suse.com> (raw)

From: Jeff Mahoney <jeffm@suse.com>

Hi all -

I recently had a bug report where xfs_repair in the dracut initramfs
environment was crashing.  It turned out to be due to systemd setting
up cgroup pids limits and pthread_create was failing.  The "real" fix
is to remove that limit, but it created a easily reproducable scenario
with which to test thread creation failure recovery.  A combination of
a small pids limit and MALLOC_PERTURB_ shook out a few bugs.  There's
more work to be done here since it should probably fall back to single
threads whenever we can't create a thread, but I only tackled the cases
that were already being handled gracefully instead of erroring out.

-Jeff

---

Jeff Mahoney (3):
  xfs_repair: clear pthread_t when pthread_create fails
  xfs_repair: add prefetch trace calls to debug thread creation failures
  xfs_repair: fix thread creation failure recovery

 repair/prefetch.c | 49 ++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 42 insertions(+), 7 deletions(-)

-- 
2.7.1


             reply	other threads:[~2017-01-17  4:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17  4:39 jeffm [this message]
2017-01-17  4:39 ` [PATCH 1/3] xfs_repair: clear pthread_t when pthread_create fails jeffm
2017-06-15 19:11   ` Eric Sandeen
2017-01-17  4:39 ` [PATCH 2/3] xfs_repair: add prefetch trace calls to debug thread creation failures jeffm
2017-06-15 19:11   ` Eric Sandeen
2017-01-17  4:39 ` [PATCH 3/3] xfs_repair: fix thread creation failure recovery jeffm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484627973-11535-1-git-send-email-jeffm@suse.com \
    --to=jeffm@suse.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).