public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Samuel <csamuel@vpac.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: XFS filesystem shutting down on linux 2.6.28.10 (xfs_rename)
Date: Wed, 5 Aug 2009 14:32:44 +1000 (EST)	[thread overview]
Message-ID: <1485133780.793941249446764456.JavaMail.root@mail.vpac.org> (raw)
In-Reply-To: <4A790A09.8050502@sandeen.net>


----- "Eric Sandeen" <sandeen@sandeen.net> wrote:

Hi Eric,

Thanks for the speedy response!

> I'll take a look. [...]

Thanks for that.

> Is there any chance you could instrument xfs_rename so that for every
> goto abort_return and goto error_return you add a printk so we know
> which one you hit?

Happy to do that, though we won't be able to reboot into it
until another crash fails (the impact on the HPC jobs is too
large I'm afraid :-( ).

> Maybe something like:
> 
> printk("line %s error %d\n", __LINE__, error);
> 
> just before each goto, with appropriate braces {} sprinkled in as
> necessary?
> 
> I can send a patch if that helps.

If you could that would be great, we'd really appreciate it
(I'm about to disappear into an afternoon of meetings now).

> Sorry for the brute-force debugging but not at all sure
> yet what this may be.

No worries, quite understand!

All the best,
Chris
-- 
Christopher Samuel - (03) 9925 4751 - Systems Manager
 The Victorian Partnership for Advanced Computing
 P.O. Box 201, Carlton South, VIC 3053, Australia
VPAC is a not-for-profit Registered Research Agency

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2009-08-05  4:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <816101050.793011249444717925.JavaMail.root@mail.vpac.org>
2009-08-05  4:00 ` XFS filesystem shutting down on linux 2.6.28.10 (xfs_rename) Chris Samuel
2009-08-05  4:26   ` Eric Sandeen
2009-08-05  4:32     ` Chris Samuel [this message]
2009-08-10  8:20   ` Krzysztof Błaszkowski
2009-08-10 14:29   ` Eric Sandeen
2009-08-10 22:52     ` Chris Samuel
2009-08-10 23:20       ` Eric Sandeen
     [not found] <1055011478.793231249445110983.JavaMail.root@mail.vpac.org>
2009-08-05  4:05 ` Chris Samuel
     [not found] <7684694.1055541249875694469.JavaMail.root@mail.vpac.org>
2009-08-10  3:43 ` Chris Samuel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485133780.793941249446764456.JavaMail.root@mail.vpac.org \
    --to=csamuel@vpac.org \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox