linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Cc: Patrick Dung <mpatdung@gmail.com>
Subject: [PATCH 0/2] divide indirect blocks fairly on delalloc extent split
Date: Fri,  3 Feb 2017 13:34:23 -0500	[thread overview]
Message-ID: <1486146865-47286-1-git-send-email-bfoster@redhat.com> (raw)

Hi all,

These are a couple fixes for dealing with delalloc indlen reservations
that happen to be less than the worst case res as calculated by
xfs_bmap_worst_indlen().

Patch 1 prevents an unexpected in-core allocation and assert failure in
the delalloc extent merge case. Patch 2 reworks xfs_bmap_split_indlen()
to more fairly divide indlen blocks when an extent is split and the
existing reservation is not sufficient. The current scheme doesn't
properly deal with extents that are already under-reserved and can lead
to indlen == 0 cases fairly easily.

The latter issue was reported by Patrick[1] and reproduced simply by
copying a large sparse vdisk image using 'cp --sparse=always.' These
patches survive xfstests with and without rmapbt without regression.

Brian

[1] http://www.spinics.net/lists/linux-xfs/msg03935.html

Brian Foster (2):
  xfs: handle indlen shortage on delalloc extent merge
  xfs: split indlen reservations fairly when under reserved

 fs/xfs/libxfs/xfs_bmap.c | 67 +++++++++++++++++++++++++++++++++---------------
 1 file changed, 46 insertions(+), 21 deletions(-)

-- 
2.7.4


             reply	other threads:[~2017-02-03 18:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-03 18:34 Brian Foster [this message]
2017-02-03 18:34 ` [PATCH 1/2] xfs: handle indlen shortage on delalloc extent merge Brian Foster
2017-02-07  1:14   ` Darrick J. Wong
2017-02-03 18:34 ` [PATCH 2/2] xfs: split indlen reservations fairly when under reserved Brian Foster
2017-02-03 22:02   ` Darrick J. Wong
2017-02-06 15:34     ` Brian Foster
2017-02-07  1:41       ` Darrick J. Wong
2017-02-07 13:37         ` Brian Foster
2017-02-07  1:21   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486146865-47286-1-git-send-email-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mpatdung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).