From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v3 0/2] xfs: quotacheck vs. dquot reclaim deadlock
Date: Fri, 21 Apr 2017 08:22:11 -0400 [thread overview]
Message-ID: <1492777333-60156-1-git-send-email-bfoster@redhat.com> (raw)
Hi all,
This incorporates Dave's feedback from review of v2 with one exception:
- After taking another look at xfs_qm_quotacheck(), it appears to
intentionally jump to the normal exit path of the function in various
error situations. I therefore opted to not to create a new error label
for post delwri submit errors, since we still do the cancellation in
the case of success as well. If desired, we can append a broader
refactoring patch for that function, separate from the patches that
fix bugs.
Brian
v3:
- Dropped the rfc/experiment patch.
- Created a _delwri_cancel() helper function.
- Refactored _delwri_pushbuf() to expect an unlocked buffer.
- Updated _delwri_pushbuf() with more detailed comments around delwri
queue logic and reference counting.
v2: http://www.spinics.net/lists/linux-xfs/msg04483.html
- Added quotacheck error handling fixup patch.
- Push buffers with flush locked dquots for deadlock avoidance rather
than bypass dquot reclaim.
- Added RFC patch for quotacheck early buffer list submission.
v1: http://www.spinics.net/lists/linux-xfs/msg04304.html
Brian Foster (2):
xfs: fix up quotacheck buffer list error handling
xfs: push buffer of flush locked dquot to avoid quotacheck deadlock
fs/xfs/xfs_buf.c | 84 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
fs/xfs/xfs_buf.h | 2 ++
fs/xfs/xfs_qm.c | 35 ++++++++++++++++++-----
fs/xfs/xfs_trace.h | 1 +
4 files changed, 115 insertions(+), 7 deletions(-)
--
2.7.4
next reply other threads:[~2017-04-21 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 12:22 Brian Foster [this message]
2017-04-21 12:22 ` [PATCH v3 1/2] xfs: fix up quotacheck buffer list error handling Brian Foster
2017-04-21 21:28 ` Darrick J. Wong
2017-04-21 12:22 ` [PATCH v3 2/2] xfs: push buffer of flush locked dquot to avoid quotacheck deadlock Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492777333-60156-1-git-send-email-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox