Re: [PATCH v3 04/20] fs: check for writeback errors after syncing out buffers in generic_file_fsync

Christoph Hellwig
2017-04-24T15:23:36Z

> out:
> inode_unlock(inode);
> - return ret;
> + err = filemap_check_errors(inode->i_mapping);
> + return ret ? : err;

Can you spell out the whole unary operation instead of this weird GCC
extension?

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>