Re: [PATCH v3 09/20] 9p: set mapping error when writeback fails in launder_page

Jan Kara
2017-04-24T15:57:59Z

On Mon 24-04-17 09:22:48, Jeff Layton wrote:
> launder_page is just writeback under the page lock. We still need to
> mark the mapping for errors there when they occur.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

Honza

> ---
> fs/9p/vfs_addr.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fs/9p/vfs_addr.c b/fs/9p/vfs_addr.c
> index adaf6f6dd858..7af6e6501698 100644
> --- a/fs/9p/vfs_addr.c
> +++ b/fs/9p/vfs_addr.c
> @@ -223,8 +223,11 @@ static int v9fs_launder_page(struct page *page)
> v9fs_fscache_wait_on_page_write(inode, page);
> if (clear_page_dirty_for_io(page)) {
> retval = v9fs_vfs_writepage_locked(page);
> - if (retval)
> + if (retval) {
> + if (retval != -EAGAIN)
> + mapping_set_error(page->mapping, retval);
> return retval;
> + }
> }
> return 0;
> }
> --
> 2.9.3
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR