public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: "Darrick J . Wong" <darrick.wong@oracle.com>,
	Christoph Hellwig <hch@lst.de>, Theodore Ts'o <tytso@mit.edu>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	Mark Fasheh <mfasheh@versity.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/5] VFS API for getting filesystem's UUID
Date: Thu, 27 Apr 2017 11:59:29 +0300	[thread overview]
Message-ID: <1493283574-1497-1-git-send-email-amir73il@gmail.com> (raw)

Miklos,

As you observed, the sb->s_uuid field is not always filled by filesystems.

Consumers, like overlayfs, that wish to use this field can check if is
zeroed out as an indication for valid value.

Christoph suggested to make the test more explicit and require the
filesystems that fill the s_uuid field to set a super block flag.

Do you agree with the proposed API?

The first patch in the series defines the flag.
If you push this patch through your tree to Al or Linus, then filesystem
maintainers could later pick the individual patches to their trees.

The xfs patch is based on a patch I already sent to Darrick for filling
out the s_uuid field.

Thanks,
Amir.

Amir Goldstein (5):
  vfs: define a flag to indicate sb->s_uuid is available
  ext4: set the super block SB_I_HAVE_UUID flag
  f2fs: set the super block SB_I_HAVE_UUID flag
  ocfs2: set the super block SB_I_HAVE_UUID flag
  xfs: set the super block SB_I_HAVE_UUID flag

 fs/ext4/super.c    | 1 +
 fs/f2fs/super.c    | 1 +
 fs/ocfs2/super.c   | 1 +
 fs/xfs/xfs_mount.c | 1 +
 include/linux/fs.h | 3 +++
 5 files changed, 7 insertions(+)

-- 
2.7.4


             reply	other threads:[~2017-04-27  8:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27  8:59 Amir Goldstein [this message]
2017-04-27  8:59 ` [PATCH 1/5] vfs: define a flag to indicate sb->s_uuid is available Amir Goldstein
2017-04-27 19:34   ` Darrick J. Wong
2017-04-27  8:59 ` [PATCH 2/5] ext4: set the super block SB_I_HAVE_UUID flag Amir Goldstein
2017-04-27  8:59 ` [PATCH 3/5] f2fs: " Amir Goldstein
2017-04-27  8:59 ` [PATCH 4/5] ocfs2: " Amir Goldstein
2017-04-27  8:59 ` [PATCH 5/5] xfs: " Amir Goldstein
2017-04-27  9:09 ` [PATCH 0/5] VFS API for getting filesystem's UUID Miklos Szeredi
2017-04-29 23:01 ` Dave Chinner
2017-04-30  0:54   ` Al Viro
2017-04-30  5:04     ` Amir Goldstein
2017-04-30  5:01   ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493283574-1497-1-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=hch@lst.de \
    --cc=jaegeuk@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mfasheh@versity.com \
    --cc=miklos@szeredi.hu \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox