linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: "Darrick J . Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Miklos Szeredi <miklos@szeredi.hu>, Theodore Tso <tytso@mit.edu>,
	Richard Weinberger <richard@nod.at>,
	Mark Fasheh <mfasheh@versity.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	David Howells <dhowells@redhat.com>, Shaohua Li <shli@kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH v2 0/8] hoist uuid helpers from xfs to linux/uuid.h
Date: Thu,  4 May 2017 16:26:15 +0300	[thread overview]
Message-ID: <1493904383-2187-1-git-send-email-amir73il@gmail.com> (raw)

Darick,

I moved some code around to be able to hoist all the generic
xfs uuid helpers to linux/uuid.h, so that other filesystems
and uuid related code in the kernel can use them.

Let me know what you think of the outcome.

I did not find any uuid related regressions with xfs.
Specifically, the following xfstests exercise these changes:
xfs/045 xfs/073 xfs/077 (multi uuid mount)
generic/079 xfs/238 xfs/269 xfs/062 (fshandle)

Some of these helpers are quite similar to thier uuid_{le|be}
variants in linux/uuid.h, but at the moment I don't see xfs
or any filesystem starting to use the uuid_{le|be} helpers,
so we probably have to live with this duplicity for a while
longer.

Amir.

Amir Goldstein (8):
  xfs: use uuid_copy() helper to abstract uuid_t
  xfs: re-define uuid_t as common struct uuid_v1
  xfs: dismiss xfs_uu_t
  xfs: namespace the helper uuid_getnodeuniq()
  md: namespace private helper names
  linux/uuid.h: hoist helpers uuid_equal() and uuid_copy() from xfs
  linux/uuid.h: hoist uuid_is_null() helper from libnvdimm
  xfs: use the common helper uuid_is_null()

 drivers/md/md.c           |  8 ++++----
 drivers/nvdimm/btt_devs.c | 10 ++--------
 fs/xfs/uuid.c             | 42 ++++++------------------------------------
 fs/xfs/uuid.h             | 14 ++------------
 fs/xfs/xfs_inode_item.c   |  8 ++------
 fs/xfs/xfs_log_recover.c  |  6 +++---
 fs/xfs/xfs_mount.c        | 10 +++++-----
 include/linux/uuid.h      | 21 +++++++++++++++++++--
 lib/uuid.c                |  3 +++
 9 files changed, 46 insertions(+), 76 deletions(-)

-- 
2.7.4


             reply	other threads:[~2017-05-04 13:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 13:26 Amir Goldstein [this message]
2017-05-04 13:26 ` [PATCH v2 1/8] xfs: use uuid_copy() helper to abstract uuid_t Amir Goldstein
2017-05-04 13:31   ` Christoph Hellwig
2017-05-04 13:26 ` [PATCH v2 2/8] xfs: re-define uuid_t as common struct uuid_v1 Amir Goldstein
2017-05-04 13:34   ` Christoph Hellwig
2017-05-04 13:57     ` Amir Goldstein
2017-05-04 13:59       ` Christoph Hellwig
2017-05-04 14:00         ` Amir Goldstein
2017-05-04 14:01           ` Christoph Hellwig
2017-05-04 14:16   ` David Howells
2017-05-04 14:18     ` Christoph Hellwig
2017-05-04 14:36     ` David Howells
2017-05-04 13:26 ` [PATCH v2 3/8] xfs: dismiss xfs_uu_t Amir Goldstein
2017-05-04 13:35   ` Christoph Hellwig
2017-05-04 13:26 ` [PATCH v2 4/8] xfs: namespace the helper uuid_getnodeuniq() Amir Goldstein
2017-05-04 13:28   ` Christoph Hellwig
2017-05-04 13:26 ` [PATCH v2 5/8] md: namespace private helper names Amir Goldstein
2017-05-04 13:26 ` [PATCH v2 6/8] linux/uuid.h: hoist helpers uuid_equal() and uuid_copy() from xfs Amir Goldstein
2017-05-04 13:26 ` [PATCH v2 7/8] linux/uuid.h: hoist uuid_is_null() helper from libnvdimm Amir Goldstein
2017-05-04 13:30   ` Christoph Hellwig
2017-05-04 13:26 ` [PATCH v2 8/8] xfs: use the common helper uuid_is_null() Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493904383-2187-1-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=darrick.wong@oracle.com \
    --cc=dhowells@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mfasheh@versity.com \
    --cc=miklos@szeredi.hu \
    --cc=richard@nod.at \
    --cc=shli@kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).