From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f178.google.com ([209.85.216.178]:32987 "EHLO mail-qt0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021AbdFMKYf (ORCPT ); Tue, 13 Jun 2017 06:24:35 -0400 Received: by mail-qt0-f178.google.com with SMTP id u12so164710842qth.0 for ; Tue, 13 Jun 2017 03:24:35 -0700 (PDT) Message-ID: <1497349472.5762.1.camel@redhat.com> Subject: Re: [PATCH v6 12/20] fs: add a new fstype flag to indicate how writeback errors are tracked From: Jeff Layton Date: Tue, 13 Jun 2017 06:24:32 -0400 In-Reply-To: <20170612124513.GC18360@infradead.org> References: <20170612122316.13244-1-jlayton@redhat.com> <20170612122316.13244-15-jlayton@redhat.com> <20170612124513.GC18360@infradead.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: Andrew Morton , Al Viro , Jan Kara , tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason , Josef Bacik , David Sterba , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org On Mon, 2017-06-12 at 05:45 -0700, Christoph Hellwig wrote: > On Mon, Jun 12, 2017 at 08:23:06AM -0400, Jeff Layton wrote: > > Add a new FS_WB_ERRSEQ flag to the fstype. Later patches will set and > > key off of that to decide what behavior should be used. > > Please invert this so that only file systems that keep the old semantics > need a flag. That's definitely what I want for the endgame here. My plan was to add this flag for now, and then eventually reverse it (or drop it) once all or most filesystems are converted. We can do it that way from the get-go if you like. It'll mean tossing in a patch add this flag to all filesystems that have an fsync operation and that use the pagecache, and then gradually remove it from them as we convert them. Which method do you prefer? -- Jeff Layton