From: Nikolay Borisov <nborisov@suse.com>
To: linux-xfs@vger.kernel.org
Cc: sandeen@redhat.com, darrick.wong@oracle.com,
Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH] xfs: Don't trim extents for fiemap
Date: Thu, 23 Nov 2017 10:06:09 +0200 [thread overview]
Message-ID: <1511424369-28740-1-git-send-email-nborisov@suse.com> (raw)
For file extents xfs currently always calls xfs_bmapi_read with not flags,
meaning extents are going to be truncated to the requested range. This is
differs than what other filesystems do (ext4/btrfs don't trim extents). So
harmonize the behavior across the filesystem by explicitly not trimming
extents when we are called from fiemap code.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
fs/xfs/xfs_iomap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
index f179bdf1644d..129550fbf898 100644
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -1008,7 +1008,8 @@ xfs_file_iomap_begin(
end_fsb = XFS_B_TO_FSB(mp, offset + length);
error = xfs_bmapi_read(ip, offset_fsb, end_fsb - offset_fsb, &imap,
- &nimaps, 0);
+ &nimaps,
+ flags & IOMAP_REPORT ? XFS_BMAPI_ENTIRE : 0);
if (error)
goto out_unlock;
--
2.7.4
next reply other threads:[~2017-11-23 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 8:06 Nikolay Borisov [this message]
2017-11-23 8:15 ` [PATCH] xfs: Don't trim extents for fiemap Christoph Hellwig
2017-11-23 8:28 ` Nikolay Borisov
2017-11-23 8:30 ` Christoph Hellwig
2017-11-23 11:35 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511424369-28740-1-git-send-email-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).