From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38232 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbdLLOfE (ORCPT ); Tue, 12 Dec 2017 09:35:04 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vBCEYheR019036 for ; Tue, 12 Dec 2017 09:35:04 -0500 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2etehsg50x-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 12 Dec 2017 09:35:03 -0500 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 12 Dec 2017 14:34:59 -0000 Subject: Re: [PATCH] xfs: include the XFS magic number in magic.h From: Mimi Zohar Date: Tue, 12 Dec 2017 09:34:56 -0500 In-Reply-To: <20171212142615.GA25327@infradead.org> References: <1513088469.3476.48.camel@linux.vnet.ibm.com> <20171212142615.GA25327@infradead.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Message-Id: <1513089296.3476.52.camel@linux.vnet.ibm.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: linux-xfs On Tue, 2017-12-12 at 06:26 -0800, Christoph Hellwig wrote: > On Tue, Dec 12, 2017 at 09:21:09AM -0500, Mimi Zohar wrote: > > Move the XFS_SB_MAGIC definition to magic.h. > > NACK. We want to keep the XFS code self-contained and no other part > of the kernel has any business knowing it anyway. IMA policy rules can be defined in terms of magic numbers, but they need to be defined in magic.h.  Please reconsider... Mimi