From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11])
	by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id
	n3K2xc8N022255 for <xfs@oss.sgi.com>; Sun, 19 Apr 2009 21:59:39 -0500
Received: from postoffice2.aconex.com (localhost [127.0.0.1])
	by cuda.sgi.com (Spam Firewall) with ESMTP id 846E3143322D
	for <xfs@oss.sgi.com>; Sun, 19 Apr 2009 20:02:07 -0700 (PDT)
Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by
	cuda.sgi.com with ESMTP id xdVw5WfIWKBCpecv for
	<xfs@oss.sgi.com>; Sun, 19 Apr 2009 20:02:07 -0700 (PDT)
Date: Mon, 20 Apr 2009 12:59:28 +1000 (EST)
From: Nathan Scott <nscott@aconex.com>
Message-ID: <1520890652.3597921240196368192.JavaMail.root@mail-au.aconex.com>
In-Reply-To: <49EBDF30.90702@sandeen.net>
Subject: Re: [PATCH, RFC] put xfs build features into the stats file
MIME-Version: 1.0
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: xfs-bounces@oss.sgi.com
Errors-To: xfs-bounces@oss.sgi.com
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>

Separate file?  That line uses a comma separator ... differs to
every other line in that stats file, painful for parsers.  And
no risk of breaking anything if its a separate file.

cheers.

----- "Eric Sandeen" <sandeen@sandeen.net> wrote:

> Running xfstests on an xfs build w/o xattrs enabled, I realized
> there's no reliable way to see if the running xfs has various
> features other than debug (which is shown in /proc/fs/xfs/stat)
> 
> What do folks think of adding the BUILD_OPTIONS to this file
> as well?
> 
> # cat /proc/fs/xfs/stat
> extent_alloc 0 0 0 0
> ...
> xpc 0 0 0
> debug 0
> features security attributes, large block numbers, no debug 
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> 
> Index: linux-2.6/fs/xfs/linux-2.6/xfs_stats.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_stats.c
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_stats.c
> @@ -89,6 +89,8 @@ xfs_read_xfsstats(
>  		0);
>  #endif
>  
> +	len += sprintf(buffer + len, "features " XFS_BUILD_OPTIONS "\n");
> +
>  	if (offset >= len) {
>  		*start = buffer;
>  		*eof = 1;
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Nathan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs