From: Chengguang Xu <cgxu519@gmx.com>
To: linux-xfs@vger.kernel.org
Cc: darrick.wong@oracle.com, bfoster@redhat.com, sandeen@sandeen.net,
Chengguang Xu <cgxu519@gmx.com>
Subject: [PATCH] xfs: use hardlimit as sub-fs size if both hard/soft limits are set
Date: Sun, 25 Mar 2018 13:16:36 +0800 [thread overview]
Message-ID: <1521954996-203628-1-git-send-email-cgxu519@gmx.com> (raw)
In current implementation, we size the fs(sub-fs via project quota) at
the soft limit and simply call it 100% used if the limit is exceeded.
It is reasonable when only a soft limit is set, but we should use the
hard limit if both hard/soft limits are set, so that quota-df reflects
the usage information more accurately.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
fs/xfs/xfs_qm_bhv.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/xfs/xfs_qm_bhv.c b/fs/xfs/xfs_qm_bhv.c
index 2be6d27..43b0fe8 100644
--- a/fs/xfs/xfs_qm_bhv.c
+++ b/fs/xfs/xfs_qm_bhv.c
@@ -35,9 +35,9 @@
{
uint64_t limit;
- limit = dqp->q_core.d_blk_softlimit ?
- be64_to_cpu(dqp->q_core.d_blk_softlimit) :
- be64_to_cpu(dqp->q_core.d_blk_hardlimit);
+ limit = dqp->q_core.d_blk_hardlimit ?
+ be64_to_cpu(dqp->q_core.d_blk_hardlimit) :
+ be64_to_cpu(dqp->q_core.d_blk_softlimit);
if (limit && statp->f_blocks > limit) {
statp->f_blocks = limit;
statp->f_bfree = statp->f_bavail =
@@ -45,9 +45,9 @@
(statp->f_blocks - dqp->q_res_bcount) : 0;
}
- limit = dqp->q_core.d_ino_softlimit ?
- be64_to_cpu(dqp->q_core.d_ino_softlimit) :
- be64_to_cpu(dqp->q_core.d_ino_hardlimit);
+ limit = dqp->q_core.d_ino_hardlimit ?
+ be64_to_cpu(dqp->q_core.d_ino_hardlimit) :
+ be64_to_cpu(dqp->q_core.d_ino_softlimit);
if (limit && statp->f_files > limit) {
statp->f_files = limit;
statp->f_ffree =
--
1.8.3.1
next reply other threads:[~2018-03-25 5:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 5:16 Chengguang Xu [this message]
2018-03-26 19:22 ` [PATCH] xfs: use hardlimit as sub-fs size if both hard/soft limits are set Darrick J. Wong
2018-03-26 19:43 ` Darrick J. Wong
2018-03-27 0:14 ` cgxu519
2018-04-05 1:40 ` cgxu519
2018-04-05 21:44 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521954996-203628-1-git-send-email-cgxu519@gmx.com \
--to=cgxu519@gmx.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).