From: Allison Henderson <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 15/18] xfs: Add parent pointers to rename
Date: Wed, 18 Apr 2018 15:11:23 -0700 [thread overview]
Message-ID: <1524089486-22922-16-git-send-email-allison.henderson@oracle.com> (raw)
In-Reply-To: <1524089486-22922-1-git-send-email-allison.henderson@oracle.com>
This patch removes the old parent pointer attribute during the
rename operation, and re-adds the updated parent pointer
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
---
fs/xfs/xfs_inode.c | 25 ++++++++++++++++++++-----
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 29c58b3..f0b5421 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -2990,6 +2990,8 @@ xfs_rename(
bool src_is_directory = S_ISDIR(VFS_I(src_ip)->i_mode);
int spaceres;
int error;
+ xfs_dir2_dataptr_t new_diroffset;
+ xfs_dir2_dataptr_t old_diroffset;
trace_xfs_rename(src_dp, target_dp, src_name, target_name);
@@ -3092,7 +3094,7 @@ xfs_rename(
*/
error = xfs_dir_createname(tp, target_dp, target_name,
src_ip->i_ino, &first_block, &dfops,
- spaceres, NULL);
+ spaceres, &new_diroffset);
if (error)
goto out_bmap_cancel;
@@ -3132,7 +3134,7 @@ xfs_rename(
*/
error = xfs_dir_replace(tp, target_dp, target_name,
src_ip->i_ino, &first_block, &dfops,
- spaceres, NULL);
+ spaceres, &new_diroffset);
if (error)
goto out_bmap_cancel;
@@ -3167,7 +3169,7 @@ xfs_rename(
*/
error = xfs_dir_replace(tp, src_ip, &xfs_name_dotdot,
target_dp->i_ino, &first_block, &dfops,
- spaceres, NULL);
+ spaceres, &new_diroffset);
ASSERT(error != -EEXIST);
if (error)
goto out_bmap_cancel;
@@ -3206,11 +3208,12 @@ xfs_rename(
*/
if (wip) {
error = xfs_dir_replace(tp, src_dp, src_name, wip->i_ino,
- &first_block, &dfops, spaceres, NULL);
+ &first_block, &dfops, spaceres,
+ &old_diroffset);
} else
error = xfs_dir_removename(tp, src_dp, src_name, src_ip->i_ino,
&first_block, &dfops, spaceres,
- NULL);
+ &old_diroffset);
if (error)
goto out_bmap_cancel;
@@ -3240,6 +3243,18 @@ xfs_rename(
VFS_I(wip)->i_state &= ~I_LINKABLE;
}
+ if (xfs_sb_version_hasparent(&mp->m_sb)) {
+ error = xfs_parent_add_deferred(target_dp, src_ip, target_name,
+ new_diroffset, &dfops);
+ if (error)
+ goto out_bmap_cancel;
+
+ error = xfs_parent_remove_deferred(src_dp, src_ip,
+ old_diroffset, &dfops);
+ if (error)
+ goto out_bmap_cancel;
+ }
+
xfs_trans_ichgtime(tp, src_dp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
xfs_trans_log_inode(tp, src_dp, XFS_ILOG_CORE);
if (new_parent)
--
2.7.4
next prev parent reply other threads:[~2018-04-18 22:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 22:11 [PATCH 00/18] Parent Pointers v5 Allison Henderson
2018-04-18 22:11 ` [PATCH 01/18] xfs: Move fs/xfs/xfs_attr.h to fs/xfs/libxfs/xfs_attr.h Allison Henderson
2018-05-04 22:18 ` Darrick J. Wong
2018-04-18 22:11 ` [PATCH 02/18] xfs: Add attibute set and remove helper functions Allison Henderson
2018-05-04 22:36 ` Darrick J. Wong
2018-05-05 5:15 ` Allison Henderson
2018-04-18 22:11 ` [PATCH 03/18] xfs: Set up infastructure for deferred attribute operations Allison Henderson
2018-04-18 22:11 ` [PATCH 04/18] xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred Allison Henderson
2018-04-18 22:11 ` [PATCH 05/18] xfs: Remove all strlen calls in all xfs_attr_* functions for attr names Allison Henderson
2018-04-18 22:11 ` [PATCH 06/18] xfs: get directory offset when adding directory name Allison Henderson
2018-04-18 22:11 ` [PATCH 07/18] xfs: get directory offset when removing " Allison Henderson
2018-04-18 22:11 ` [PATCH 08/18] xfs: get directory offset when replacing a " Allison Henderson
2018-04-18 22:11 ` [PATCH 09/18] xfs: add parent pointer support to attribute code Allison Henderson
2018-04-18 22:11 ` [PATCH 10/18] xfs: define parent pointer xattr format Allison Henderson
2018-04-18 22:11 ` [PATCH 11/18] xfs: extent transaction reservations for parent attributes Allison Henderson
2018-04-18 22:11 ` [PATCH 12/18] xfs: parent pointer attribute creation Allison Henderson
2018-04-18 22:11 ` [PATCH 13/18] xfs: add parent attributes to link Allison Henderson
2018-04-18 22:11 ` [PATCH 14/18] xfs: remove parent pointers in unlink Allison Henderson
2018-04-18 22:11 ` Allison Henderson [this message]
2018-04-18 22:11 ` [PATCH 16/18] xfs: Add the parent pointer support to the superblock version 5 Allison Henderson
2018-04-18 22:11 ` [PATCH 17/18] xfs: Add parent pointer ioctl Allison Henderson
2018-04-18 22:11 ` [PATCH 18/18] xfs: Add delayed attributes error tag Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524089486-22922-16-git-send-email-allison.henderson@oracle.com \
--to=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).