From: Allison Henderson <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v7 07/23] xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred
Date: Sat, 9 Jun 2018 22:04:52 -0700 [thread overview]
Message-ID: <1528607108-11059-8-git-send-email-allison.henderson@oracle.com> (raw)
In-Reply-To: <1528607108-11059-1-git-send-email-allison.henderson@oracle.com>
These routines set up set and start a new deferred attribute
operation. These functions are meant to be called by other
code needing to initiate a deferred attribute operation. We
will use these routines later in the parent pointer patches.
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
---
fs/xfs/libxfs/xfs_attr.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++++
fs/xfs/libxfs/xfs_attr.h | 5 ++++
2 files changed, 77 insertions(+)
diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
index 408a49d..c1844ae 100644
--- a/fs/xfs/libxfs/xfs_attr.c
+++ b/fs/xfs/libxfs/xfs_attr.c
@@ -477,6 +477,44 @@ xfs_attr_set(
return error;
}
+/* Sets an attribute for an inode as a deferred operation */
+int
+xfs_attr_set_deferred(
+ struct xfs_inode *dp,
+ struct xfs_defer_ops *dfops,
+ void *name,
+ unsigned int namelen,
+ void *value,
+ unsigned int valuelen,
+ int flags)
+{
+
+ struct xfs_attr_item *new;
+ char *name_value;
+
+ if (!namelen || !valuelen) {
+ ASSERT(0);
+ return -EFSCORRUPTED;
+ }
+
+ new = kmem_alloc(XFS_ATTR_ITEM_SIZEOF(namelen, valuelen),
+ KM_SLEEP|KM_NOFS);
+ name_value = ((char *)new) + sizeof(struct xfs_attr_item);
+ memset(new, 0, XFS_ATTR_ITEM_SIZEOF(namelen, valuelen));
+ new->xattri_ip = dp;
+ new->xattri_op_flags = XFS_ATTR_OP_FLAGS_SET;
+ new->xattri_name_len = namelen;
+ new->xattri_value_len = valuelen;
+ new->xattri_flags = flags;
+ memcpy(&name_value[0], name, namelen);
+ memcpy(&name_value[namelen], value, valuelen);
+
+ xfs_defer_ijoin(dfops, dp);
+ xfs_defer_add(dfops, XFS_DEFER_OPS_TYPE_ATTR, &new->xattri_list);
+
+ return 0;
+}
+
/*
* Generic handler routine to remove a name from an attribute list.
* Transitions attribute list from Btree to shortform as necessary.
@@ -565,6 +603,40 @@ xfs_attr_remove(
return error;
}
+/* Removes an attribute for an inode as a deferred operation */
+int
+xfs_attr_remove_deferred(
+ struct xfs_inode *dp,
+ struct xfs_defer_ops *dfops,
+ void *name,
+ unsigned int namelen,
+ int flags)
+{
+
+ struct xfs_attr_item *new;
+ char *name_value;
+
+ if (!namelen) {
+ ASSERT(0);
+ return -EFSCORRUPTED;
+ }
+
+ new = kmem_alloc(XFS_ATTR_ITEM_SIZEOF(namelen, 0), KM_SLEEP|KM_NOFS);
+ name_value = ((char *)new) + sizeof(struct xfs_attr_item);
+ memset(new, 0, XFS_ATTR_ITEM_SIZEOF(namelen, 0));
+ new->xattri_ip = dp;
+ new->xattri_op_flags = XFS_ATTR_OP_FLAGS_REMOVE;
+ new->xattri_name_len = namelen;
+ new->xattri_value_len = 0;
+ new->xattri_flags = flags;
+ memcpy(name_value, name, namelen);
+
+ xfs_defer_ijoin(dfops, dp);
+ xfs_defer_add(dfops, XFS_DEFER_OPS_TYPE_ATTR, &new->xattri_list);
+
+ return 0;
+}
+
/*========================================================================
* External routines when attribute list is inside the inode
*========================================================================*/
diff --git a/fs/xfs/libxfs/xfs_attr.h b/fs/xfs/libxfs/xfs_attr.h
index 33b33d3..ec26565 100644
--- a/fs/xfs/libxfs/xfs_attr.h
+++ b/fs/xfs/libxfs/xfs_attr.h
@@ -183,5 +183,10 @@ int xfs_attr_list(struct xfs_inode *dp, char *buffer, int bufsize,
int xfs_attr_args_init(struct xfs_da_args *args, struct xfs_inode *dp,
const unsigned char *name, int flags);
int xfs_attr_calc_size(struct xfs_da_args *args, int *local);
+int xfs_attr_set_deferred(struct xfs_inode *dp, struct xfs_defer_ops *dfops,
+ void *name, unsigned int name_len, void *value,
+ unsigned int valuelen, int flags);
+int xfs_attr_remove_deferred(struct xfs_inode *dp, struct xfs_defer_ops *dfops,
+ void *name, unsigned int namelen, int flags);
#endif /* __XFS_ATTR_H__ */
--
2.7.4
next prev parent reply other threads:[~2018-06-10 5:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-10 5:04 [PATCH v7 00/23] Parent Pointers v7 Allison Henderson
2018-06-10 5:04 ` [PATCH v7 01/23] xfs: Move fs/xfs/xfs_attr.h to fs/xfs/libxfs/xfs_attr.h Allison Henderson
2018-06-10 5:04 ` [PATCH v7 02/23] xfs: Add helper function xfs_attr_try_sf_addname Allison Henderson
2018-06-10 6:58 ` Amir Goldstein
2018-06-10 15:30 ` Allison Henderson
2018-06-10 5:04 ` [PATCH v7 03/23] xfs: Add trans toggle to attr routines Allison Henderson
2018-06-13 12:11 ` Brian Foster
2018-06-14 1:27 ` Allison Henderson
2018-06-10 5:04 ` [PATCH v7 04/23] xfs: Add attibute set and helper functions Allison Henderson
2018-06-10 5:04 ` [PATCH v7 05/23] xfs: Add attibute remove " Allison Henderson
2018-06-10 5:04 ` [PATCH v7 06/23] xfs: Set up infastructure for deferred attribute operations Allison Henderson
2018-06-13 15:18 ` Brian Foster
2018-06-14 1:28 ` Allison Henderson
2018-06-14 11:13 ` Brian Foster
2018-06-10 5:04 ` Allison Henderson [this message]
2018-06-10 5:04 ` [PATCH v7 08/23] xfs: Remove all strlen calls in all xfs_attr_* functions for attr names Allison Henderson
2018-06-10 5:04 ` [PATCH v7 09/23] xfs: get directory offset when adding directory name Allison Henderson
2018-06-10 5:04 ` [PATCH v7 10/23] xfs: get directory offset when removing " Allison Henderson
2018-06-10 5:04 ` [PATCH v7 11/23] xfs: get directory offset when replacing a " Allison Henderson
2018-06-10 5:04 ` [PATCH v7 12/23] xfs: add parent pointer support to attribute code Allison Henderson
2018-06-10 5:04 ` [PATCH v7 13/23] xfs: define parent pointer xattr format Allison Henderson
2018-06-10 5:04 ` [PATCH v7 14/23] xfs: extent transaction reservations for parent attributes Allison Henderson
2018-06-10 5:05 ` [PATCH v7 15/23] xfs: Hold inode locks in xfs_ialloc Allison Henderson
2018-06-10 5:05 ` [PATCH v7 16/23] xfs: parent pointer attribute creation Allison Henderson
2018-06-10 5:05 ` [PATCH v7 17/23] xfs: add parent attributes to link Allison Henderson
2018-06-10 5:05 ` [PATCH v7 18/23] xfs: remove parent pointers in unlink Allison Henderson
2018-06-10 5:05 ` [PATCH v7 19/23] xfs: Add parent pointers to rename Allison Henderson
2018-06-10 13:39 ` Amir Goldstein
2018-06-10 17:34 ` Allison Henderson
2018-06-10 5:05 ` [PATCH v7 20/23] xfs: Add the parent pointer support to the superblock version 5 Allison Henderson
2018-06-10 5:05 ` [PATCH v7 21/23] xfs: Add helper function xfs_attr_list_context_init Allison Henderson
2018-06-10 5:05 ` [PATCH v7 22/23] xfs: Add parent pointer ioctl Allison Henderson
2018-06-10 5:05 ` [PATCH v7 23/23] xfs: Add delayed attributes error tag Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528607108-11059-8-git-send-email-allison.henderson@oracle.com \
--to=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).