From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:40636 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726913AbfFJFIY (ORCPT ); Mon, 10 Jun 2019 01:08:24 -0400 Date: Mon, 10 Jun 2019 01:08:20 -0400 (EDT) From: Pankaj Gupta Message-ID: <1533125860.33764157.1560143300908.JavaMail.zimbra@redhat.com> In-Reply-To: References: <20190521133713.31653-1-pagupta@redhat.com> <20190521133713.31653-5-pagupta@redhat.com> Subject: Re: [PATCH v10 4/7] dm: enable synchronous dax MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dan Williams Cc: linux-nvdimm , Linux Kernel Mailing List , virtualization@lists.linux-foundation.org, KVM list , linux-fsdevel , Linux ACPI , Qemu Developers , linux-ext4 , linux-xfs , device-mapper development , Ross Zwisler , Vishal L Verma , Dave Jiang , "Michael S. Tsirkin" , Jason Wang , Matthew Wilcox , "Rafael J. Wysocki" , Christoph Hellwig , Len Brown , Jan Kara , Theodore Ts'o , Andreas Dilger , "Darrick J. Wong" , lcapitulino@redhat.com, Kevin Wolf , Igor Mammedov , jmoyer , Nitesh Narayan Lal , Rik van Riel , Stefan Hajnoczi , Andrea Arcangeli , David Hildenbrand , david , cohuck@redhat.com, Xiao Guangrong , Paolo Bonzini , yuval shaia , Adam Borowski , jstaron@google.com, Randy Dunlap , Mike Snitzer > On Tue, May 21, 2019 at 6:43 AM Pankaj Gupta wrote: > > > > This patch sets dax device 'DAXDEV_SYNC' flag if all the target > > devices of device mapper support synchrononous DAX. If device > > mapper consists of both synchronous and asynchronous dax devices, > > we don't set 'DAXDEV_SYNC' flag. > > > > Signed-off-by: Pankaj Gupta > > --- > > drivers/md/dm-table.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c > > index cde3b49b2a91..1cce626ff576 100644 > > --- a/drivers/md/dm-table.c > > +++ b/drivers/md/dm-table.c > > @@ -886,10 +886,17 @@ static int device_supports_dax(struct dm_target *ti, > > struct dm_dev *dev, > > return bdev_dax_supported(dev->bdev, PAGE_SIZE); > > } > > > > +static int device_synchronous(struct dm_target *ti, struct dm_dev *dev, > > + sector_t start, sector_t len, void *data) > > +{ > > + return dax_synchronous(dev->dax_dev); > > +} > > + > > static bool dm_table_supports_dax(struct dm_table *t) > > { > > struct dm_target *ti; > > unsigned i; > > + bool dax_sync = true; > > > > /* Ensure that all targets support DAX. */ > > for (i = 0; i < dm_table_get_num_targets(t); i++) { > > @@ -901,7 +908,14 @@ static bool dm_table_supports_dax(struct dm_table *t) > > if (!ti->type->iterate_devices || > > !ti->type->iterate_devices(ti, device_supports_dax, > > NULL)) > > return false; > > + > > + /* Check devices support synchronous DAX */ > > + if (dax_sync && > > + !ti->type->iterate_devices(ti, device_synchronous, > > NULL)) > > + dax_sync = false; > > Looks like this needs to be rebased on the current state of v5.2-rc, > and then we can nudge Mike for an ack. Sorry! for late reply due to vacations. I will rebase the series on v5.2-rc4 and send a v11. Thanks, Pankaj Yes, >