From: Waiman Long <longman@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Dave Chinner <dchinner@redhat.com>,
Waiman Long <longman@redhat.com>
Subject: [PATCH 0/2] xfs: Use wake_q for waking up log space waiters
Date: Thu, 23 Aug 2018 12:26:08 -0400 [thread overview]
Message-ID: <1535041570-24102-1-git-send-email-longman@redhat.com> (raw)
While running the AIM7 microbenchmark, it was found that there was
a severe spinlock contention problem in the current XFS log space
reservation code. To alleviate the problem, the log space waiter
waiting and waking functions are modified to use the wake_q for waking
up waiters without holding the lock so as to reduce the lock hold time.
The result was a 4X performance improvement in that microbenchmark
which is worth persuing.
Patch 1 is an enablement patch to make wake_q service available to
kernel modules.
Patch 2 changes the XFS log space reservation code to use wake_q for
task wakeup.
Waiman Long (2):
sched/core: Export wake_q functions to kernel modules
xfs: Use wake_q for waking up log space waiters
fs/xfs/xfs_log.c | 48 ++++++++++++++++++++++++++++++++++----------
include/linux/sched/wake_q.h | 5 +++++
kernel/sched/core.c | 2 ++
3 files changed, 44 insertions(+), 11 deletions(-)
--
1.8.3.1
next reply other threads:[~2018-08-23 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 16:26 Waiman Long [this message]
2018-08-23 16:26 ` [PATCH 1/2] sched/core: Export wake_q functions to kernel modules Waiman Long
2018-08-23 16:26 ` [PATCH 2/2] xfs: Use wake_q for waking up log space waiters Waiman Long
2018-08-24 0:30 ` Dave Chinner
2018-08-24 21:54 ` Waiman Long
2018-08-26 21:02 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535041570-24102-1-git-send-email-longman@redhat.com \
--to=longman@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).