From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: sandeen@redhat.com, darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 2/4] libxfs: fix libxfs_trans_alloc callsite problems
Date: Tue, 18 Sep 2018 11:55:03 -0700 [thread overview]
Message-ID: <153729690308.13178.3248197307018181036.stgit@magnolia> (raw)
In-Reply-To: <153729689066.13178.8524619838625486047.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
Fix some incorrect libxfs_trans_alloc callers to check return values
correctly.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
mkfs/proto.c | 4 +++-
mkfs/xfs_mkfs.c | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/mkfs/proto.c b/mkfs/proto.c
index 7186036e..9eb15ab0 100644
--- a/mkfs/proto.c
+++ b/mkfs/proto.c
@@ -192,7 +192,9 @@ rsvfile(
/*
* update the inode timestamp, mode, and prealloc flag bits
*/
- libxfs_trans_alloc(mp, &tres, 0, 0, 0, &tp);
+ error = -libxfs_trans_alloc(mp, &tres, 0, 0, 0, &tp);
+ if (error)
+ fail(_("allocating transaction for a file"), error);
libxfs_trans_ijoin(tp, ip, 0);
VFS_I(ip)->i_mode &= ~S_ISUID;
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 2e53c1e8..c6ef3a71 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -3677,7 +3677,7 @@ initialise_ag_freespace(
struct xfs_trans_res tres = {0};
int c;
- c = libxfs_trans_alloc(mp, &tres, worst_freelist, 0, 0, &tp);
+ c = -libxfs_trans_alloc(mp, &tres, worst_freelist, 0, 0, &tp);
if (c)
res_failed(c);
next prev parent reply other threads:[~2018-09-19 0:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 18:54 [PATCH 0/4] xfsprogs-4.19: transaction cleanups Darrick J. Wong
2018-09-18 18:54 ` [PATCH 1/4] libxfs: port kernel transaction code Darrick J. Wong
2018-09-18 18:55 ` Darrick J. Wong [this message]
2018-09-18 18:55 ` [PATCH 3/4] libxfs: fix xfs_trans_alloc reservation abuse Darrick J. Wong
2018-09-18 18:55 ` [PATCH 4/4] libxfs: check libxfs_trans_commit return values Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153729690308.13178.3248197307018181036.stgit@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).