From: Eric Sandeen <sandeen@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 11/18] xfsprogs: misc static function warning fixes
Date: Wed, 10 Oct 2018 15:01:15 -0500 [thread overview]
Message-ID: <1539201682-22198-12-git-send-email-sandeen@redhat.com> (raw)
In-Reply-To: <1539201682-22198-1-git-send-email-sandeen@redhat.com>
The last handful of static symbol warning cleanups for misc remaining
issues.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
libxfs/init.h | 1 +
libxfs/rdwr.c | 2 --
repair/phase2.c | 2 --
repair/scan.h | 2 ++
scrub/xfs_scrub.h | 2 ++
5 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/libxfs/init.h b/libxfs/init.h
index 2cda895..b23e493 100644
--- a/libxfs/init.h
+++ b/libxfs/init.h
@@ -7,6 +7,7 @@
#define LIBXFS_INIT_H
struct stat;
+extern int use_xfs_buf_lock;
extern int platform_check_ismounted (char *path, char *block,
struct stat *sptr, int verbose);
diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index e580aba..a00360e 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -712,8 +712,6 @@ struct list_head lock_buf_list = {&lock_buf_list, &lock_buf_list};
int lock_buf_count = 0;
#endif
-extern int use_xfs_buf_lock;
-
static struct xfs_buf *
__cache_lookup(struct xfs_bufkey *key, unsigned int flags)
{
diff --git a/repair/phase2.c b/repair/phase2.c
index b92ceb8..4bd6c63 100644
--- a/repair/phase2.c
+++ b/repair/phase2.c
@@ -15,8 +15,6 @@
#include "progress.h"
#include "scan.h"
-void set_mp(xfs_mount_t *mpp);
-
/* workaround craziness in the xlog routines */
int xlog_recover_do_trans(struct xlog *log, xlog_recover_t *t, int p)
{
diff --git a/repair/scan.h b/repair/scan.h
index aa7c38d..bf1ee83 100644
--- a/repair/scan.h
+++ b/repair/scan.h
@@ -8,6 +8,8 @@
struct blkmap;
+void set_mp(xfs_mount_t *mpp);
+
int scan_lbtree(
xfs_fsblock_t root,
int nlevels,
diff --git a/scrub/xfs_scrub.h b/scrub/xfs_scrub.h
index 8b80c79..a961d8f 100644
--- a/scrub/xfs_scrub.h
+++ b/scrub/xfs_scrub.h
@@ -6,6 +6,8 @@
#ifndef XFS_SCRUB_XFS_SCRUB_H_
#define XFS_SCRUB_XFS_SCRUB_H_
+extern char *progname;
+
#define _PATH_PROC_MOUNTS "/proc/mounts"
extern unsigned int nr_threads;
--
1.8.3.1
next prev parent reply other threads:[~2018-10-11 3:25 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 20:01 [PATCH 00/18] xfsprogs: finer-grained sparse fixes Eric Sandeen
2018-10-10 20:01 ` [PATCH 01/18] xfsprogs: enable sparse checking with "make C=[12]" Eric Sandeen
2018-10-10 21:24 ` Darrick J. Wong
2018-10-10 22:18 ` [PATCH 01/18 V2] " Eric Sandeen
2018-10-11 5:57 ` Christoph Hellwig
2018-10-11 14:09 ` Eric Sandeen
2018-10-10 20:01 ` [PATCH 02/18] xfs_db: convert single-bit bitfields to bools Eric Sandeen
2018-10-11 5:58 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 03/18] xfsprogs: minor endian annotation fixes Eric Sandeen
2018-10-11 5:59 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 04/18] xfsprogs: avoid redefinition of NBBY Eric Sandeen
2018-10-11 5:59 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 05/18] xfsprogs: include headers for extern variables Eric Sandeen
2018-10-11 5:59 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 06/18] libxfs: add several zone extern declarations to libxfs_priv.h Eric Sandeen
2018-10-11 5:59 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 07/18] libxfs: silence static warnings about platform_* functions Eric Sandeen
2018-10-11 6:00 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 08/18] xfs_io: include io.h to silence static function warnings Eric Sandeen
2018-10-11 6:00 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 09/18] libxfs: silence sparse static function warnings in util.c Eric Sandeen
2018-10-11 6:00 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 10/18] avl64: export avl64_firstino / avl64_firstino from avl64.h Eric Sandeen
2018-10-11 6:01 ` Christoph Hellwig
2018-10-10 20:01 ` Eric Sandeen [this message]
2018-10-11 6:01 ` [PATCH 11/18] xfsprogs: misc static function warning fixes Christoph Hellwig
2018-10-10 20:01 ` [PATCH 12/18] xfsprogs: don't shadow global libxfs_init x variable Eric Sandeen
2018-10-11 6:02 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 13/18] xfs_io: rename global buffer variable Eric Sandeen
2018-10-11 6:02 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 14/18] xfs_logprint: fix shadow var in xlog_print_trans_buffer Eric Sandeen
2018-10-11 6:03 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 15/18] xfs_repair: fix 'bno' shadow vars in scan.c Eric Sandeen
2018-10-11 6:03 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 16/18] xfs_scrub: remove shadow var from run_scrub_phases() Eric Sandeen
2018-10-11 6:03 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 17/18] xfs_metadump: remove shadow variable Eric Sandeen
2018-10-10 21:34 ` Darrick J. Wong
2018-10-11 6:04 ` Christoph Hellwig
2018-10-10 20:01 ` [PATCH 18/18] libfrog: change project entity variable scope to local/static Eric Sandeen
2018-10-10 21:37 ` [PATCH 00/18] xfsprogs: finer-grained sparse fixes Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539201682-22198-12-git-send-email-sandeen@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).