From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] fs: move generic stat response attr handling to vfs_getattr_nosec
Date: Thu, 17 Jan 2019 13:49:35 +0000 [thread overview]
Message-ID: <15567.1547732975@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190117075320.8327-1-hch@lst.de>
Christoph Hellwig <hch@lst.de> wrote:
> generic_fillattr is an optional helper that isn't used by all
> file systems, move handling purely based on inode flags to
> vfs_getattr_nosec, which is common code.
>
> This fixes setting this flag for file systems not using generic_fillattr
> like xfs.
The only problem I have with this change is that you've moved the flag setting
to after the ->getattr() call, which means that the filesystem cannot override
it. I'm not sure that particularly matters in the case of these two flags,
but it might encourage similar things to be put there where it could matter.
David
prev parent reply other threads:[~2019-01-17 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 7:53 [PATCH] fs: move generic stat response attr handling to vfs_getattr_nosec Christoph Hellwig
2019-01-17 13:49 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15567.1547732975@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox