From: Alvin@linux.alibaba.com
To: linux-xfs@vger.kernel.org, sandeen@redhat.com
Cc: caspar@linux.alibaba.com, Alvin Zheng <Alvin@linux.alibaba.com>
Subject: [PATCH] Fix the inconsistency between the code and the manual page of mkfs.xfs.
Date: Thu, 13 Jun 2019 18:26:20 +0800 [thread overview]
Message-ID: <1560421580-22920-1-git-send-email-Alvin@linux.alibaba.com> (raw)
From: Alvin Zheng <Alvin@linux.alibaba.com>
Signed-off-by: Alvin Zheng <Alvin@linux.alibaba.com>
---
man/man8/mkfs.xfs.8 | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
index 4b8c78c..bf2ad54 100644
--- a/man/man8/mkfs.xfs.8
+++ b/man/man8/mkfs.xfs.8
@@ -115,9 +115,12 @@ When specifying parameters in units of sectors or filesystem blocks, the
.B \-s
option or the
.B \-b
-option first needs to be added to the command line.
-Failure to specify the size of the units will result in illegal value errors
-when parameters are quantified in those units.
+option can be used to specify the size of the sector or block. The
+.B \-s
+option and the
+.B \-b
+should be placed before any options in units of sectors or blocks. If the size of the block
+or sector is not specified, the default size (block: 4KiB, sector: 512B) will be used.
.PP
Many feature options allow an optional argument of 0 or 1, to explicitly
disable or enable the functionality.
@@ -136,9 +139,10 @@ The filesystem block size is specified with a
in bytes. The default value is 4096 bytes (4 KiB), the minimum is 512, and the
maximum is 65536 (64 KiB).
.IP
-To specify any options on the command line in units of filesystem blocks, this
-option must be specified first so that the filesystem block size is
-applied consistently to all options.
+If a non-default filesystem block size is specified, the option
+must be specified before any options that use filesystem block size
+units so that the non-default filesystem block size is applied
+consistently to all options.
.IP
Although
.B mkfs.xfs
@@ -895,9 +899,10 @@ is 512 bytes. The minimum value for sector size is
must be a power of 2 size and cannot be made larger than the
filesystem block size.
.IP
-To specify any options on the command line in units of sectors, this
-option must be specified first so that the sector size is
-applied consistently to all options.
+If a non-default sector size is specified, the option
+must be specified before any options that use sector size
+units so that the non-default sector size is applied
+consistently to all options.
.RE
.TP
.BI \-L " label"
--
1.8.3.1
next reply other threads:[~2019-06-13 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 10:26 Alvin [this message]
2019-07-10 21:44 ` [PATCH] Fix the inconsistency between the code and the manual page of mkfs.xfs Eric Sandeen
2019-07-10 21:49 ` Eric Sandeen
2019-07-11 2:45 ` Alvin Zheng
-- strict thread matches above, loose matches on Subject: below --
2019-06-12 6:23 Alvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560421580-22920-1-git-send-email-Alvin@linux.alibaba.com \
--to=alvin@linux.alibaba.com \
--cc=caspar@linux.alibaba.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox