From: Ian Kent <raven@themaw.net>
To: linux-xfs <linux-xfs@vger.kernel.org>
Cc: Dave Chinner <dchinner@redhat.com>,
David Howells <dhowells@redhat.com>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: [PATCH 07/10] xfs: mount-api - add xfs_fc_free()
Date: Mon, 24 Jun 2019 10:59:02 +0800 [thread overview]
Message-ID: <156134514204.2519.9597800141023778002.stgit@fedora-28> (raw)
In-Reply-To: <156134510205.2519.16185588460828778620.stgit@fedora-28>
Add the fs_context_operations method .free that performs fs
context cleanup on context release.
Signed-off-by: Ian Kent <raven@themaw.net>
---
fs/xfs/xfs_super.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 7326b21b32d1..0a771e1390e7 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -2413,10 +2413,33 @@ static const struct super_operations xfs_super_operations = {
.free_cached_objects = xfs_fs_free_cached_objects,
};
+static void xfs_fc_free(struct fs_context *fc)
+{
+ struct xfs_fs_context *ctx = fc->fs_private;
+ struct xfs_mount *mp = fc->s_fs_info;
+
+ if (mp) {
+ /*
+ * If an error occurs before ownership the xfs_mount
+ * info struct is passed to xfs by the VFS (by assigning
+ * it to sb->s_fs_info and clearing the corresponding
+ * fs_context field, done before calling fill super via
+ * .get_tree()) there may be some strings to cleanup.
+ */
+ if (mp->m_logname)
+ kfree(mp->m_logname);
+ if (mp->m_rtname)
+ kfree(mp->m_rtname);
+ kfree(mp);
+ }
+ kfree(ctx);
+}
+
static const struct fs_context_operations xfs_context_ops = {
.parse_param = xfs_parse_param,
.get_tree = xfs_get_tree,
.reconfigure = xfs_reconfigure,
+ .free = xfs_fc_free,
};
static struct file_system_type xfs_fs_type = {
next prev parent reply other threads:[~2019-06-24 3:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 2:58 [PATCH 01/10] xfs: mount-api - add fs parameter description Ian Kent
2019-06-24 2:58 ` [PATCH 02/10] xfs: mount-api - refactor suffix_kstrtoint() Ian Kent
2019-06-24 17:29 ` Darrick J. Wong
2019-06-24 22:35 ` Dave Chinner
2019-06-24 23:06 ` Darrick J. Wong
2019-06-24 23:34 ` Ian Kent
2019-06-24 2:58 ` [PATCH 03/10] xfs: mount-api - add xfs_parse_param() Ian Kent
2019-06-24 17:26 ` Darrick J. Wong
2019-06-24 23:47 ` Ian Kent
2019-06-27 3:35 ` Ian Kent
2019-06-24 2:58 ` [PATCH 04/10] xfs: mount-api - refactor xfs_fs_fill_super() Ian Kent
2019-06-24 2:58 ` [PATCH 05/10] xfs: mount-api - add xfs_get_tree() Ian Kent
2019-06-24 17:44 ` Darrick J. Wong
2019-06-24 23:52 ` Ian Kent
2019-06-24 2:58 ` [PATCH 06/10] xfs: mount api - add xfs_reconfigure() Ian Kent
2019-06-24 17:55 ` Darrick J. Wong
2019-06-25 0:00 ` Ian Kent
2019-06-24 2:59 ` Ian Kent [this message]
2019-06-24 17:56 ` [PATCH 07/10] xfs: mount-api - add xfs_fc_free() Darrick J. Wong
2019-06-25 0:01 ` Ian Kent
2019-06-24 2:59 ` [PATCH 08/10] xfs: mount-api - switch to new mount-api Ian Kent
2019-06-24 2:59 ` [PATCH 09/10] xfs: mount-api - remove legacy mount functions Ian Kent
2019-06-24 2:59 ` [PATCH 10/10] xfs: mount-api - rename xfs_fill_super() Ian Kent
2019-06-24 17:59 ` Darrick J. Wong
2019-06-24 17:59 ` [PATCH 01/10] xfs: mount-api - add fs parameter description Darrick J. Wong
2019-06-25 10:34 ` Christoph Hellwig
2019-06-25 10:55 ` Ian Kent
2019-08-21 14:52 ` Eric Sandeen
2019-08-22 9:05 ` Ian Kent
2019-08-22 17:17 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156134514204.2519.9597800141023778002.stgit@fedora-28 \
--to=raven@themaw.net \
--cc=dchinner@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox