Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: linux-xfs <linux-xfs@vger.kernel.org>
Cc: Dave Chinner <dchinner@redhat.com>,
	David Howells <dhowells@redhat.com>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Eric Sandeen <sandeen@sandeen.net>
Subject: [PATCH v2 08/15] xfs: mount-api - add xfs_get_tree()
Date: Fri, 23 Aug 2019 08:59:59 +0800	[thread overview]
Message-ID: <156652199954.2607.8863934346265980917.stgit@fedora-28> (raw)
In-Reply-To: <156652158924.2607.14608448087216437699.stgit@fedora-28>

Add the fs_context_operations method .get_tree that validates
mount options and fills the super block as previously done
by the file_system_type .mount method.

Signed-off-by: Ian Kent <raven@themaw.net>
---
 fs/xfs/xfs_super.c |   47 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index d3fc9938987d..7de64808eb00 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1904,6 +1904,52 @@ xfs_fs_fill_super(
 	return error;
 }
 
+STATIC int
+xfs_fill_super(
+	struct super_block	*sb,
+	struct fs_context	*fc)
+{
+	struct xfs_fs_context	*ctx = fc->fs_private;
+	struct xfs_mount	*mp = sb->s_fs_info;
+	int			silent = fc->sb_flags & SB_SILENT;
+	int			error = -ENOMEM;
+
+	mp->m_super = sb;
+
+	/*
+	 * set up the mount name first so all the errors will refer to the
+	 * correct device.
+	 */
+	mp->m_fsname = kstrndup(sb->s_id, MAXNAMELEN, GFP_KERNEL);
+	if (!mp->m_fsname)
+		return -ENOMEM;
+	mp->m_fsname_len = strlen(mp->m_fsname) + 1;
+
+	error = xfs_validate_params(mp, ctx, false);
+	if (error)
+		goto out_free_fsname;
+
+	error = __xfs_fs_fill_super(mp, silent);
+	if (error)
+		goto out_free_fsname;
+
+	return 0;
+
+ out_free_fsname:
+	sb->s_fs_info = NULL;
+	xfs_free_fsname(mp);
+	kfree(mp);
+
+	return error;
+}
+
+STATIC int
+xfs_get_tree(
+	struct fs_context	*fc)
+{
+	return vfs_get_block_super(fc, xfs_fill_super);
+}
+
 STATIC void
 xfs_fs_put_super(
 	struct super_block	*sb)
@@ -1976,6 +2022,7 @@ static const struct super_operations xfs_super_operations = {
 
 static const struct fs_context_operations xfs_context_ops = {
 	.parse_param = xfs_parse_param,
+	.get_tree    = xfs_get_tree,
 };
 
 static struct file_system_type xfs_fs_type = {


  parent reply	other threads:[~2019-08-23  1:09 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23  0:59 [PATCH v2 00/15] xfs: mount API patch series Ian Kent
2019-08-23  0:59 ` [PATCH v2 01/15] vfs: Create fs_context-aware mount_bdev() replacement Ian Kent
2019-08-23  0:59 ` [PATCH v2 02/15] xfs: mount-api - add fs parameter description Ian Kent
2019-08-27 12:39   ` Brian Foster
2019-08-30 10:31     ` Ian Kent
2019-08-30 11:56       ` Brian Foster
2019-09-17  3:13     ` Ian Kent
2019-09-17 12:10       ` Brian Foster
2019-09-18  3:43         ` Ian Kent
2019-09-18  3:49           ` Ian Kent
2019-08-23  0:59 ` [PATCH v2 03/15] xfs: mount-api - refactor suffix_kstrtoint() Ian Kent
2019-08-27 12:40   ` Brian Foster
2019-08-30 10:33     ` Ian Kent
2019-09-17  4:31     ` Ian Kent
2019-09-17 12:10       ` Brian Foster
2019-08-23  0:59 ` [PATCH v2 04/15] xfs: mount-api - refactor xfs_parseags() Ian Kent
2019-08-27 12:40   ` Brian Foster
2019-08-23  0:59 ` [PATCH v2 05/15] xfs: mount-api - make xfs_parse_param() take context .parse_param() args Ian Kent
2019-08-26 19:19   ` Eric Sandeen
2019-08-26 19:31     ` Eric Sandeen
2019-08-26 19:32       ` Eric Sandeen
2019-08-30 10:23       ` Ian Kent
2019-08-27 12:41   ` Brian Foster
2019-08-27 15:10     ` Darrick J. Wong
2019-08-27 15:15       ` Eric Sandeen
2019-08-28  0:55         ` Ian Kent
2019-08-30 10:51     ` Ian Kent
2019-08-23  0:59 ` [PATCH v2 06/15] xfs: mount-api - move xfs_parseargs() validation to a helper Ian Kent
2019-08-27 12:41   ` Brian Foster
2019-08-30 10:55     ` Ian Kent
2019-08-23  0:59 ` [PATCH v2 07/15] xfs: mount-api - refactor xfs_fs_fill_super() Ian Kent
2019-08-27 12:42   ` Brian Foster
2019-08-30 10:56     ` Ian Kent
2019-08-23  0:59 ` Ian Kent [this message]
2019-08-28 13:27   ` [PATCH v2 08/15] xfs: mount-api - add xfs_get_tree() Brian Foster
2019-08-30 11:01     ` Ian Kent
2019-08-23  1:00 ` [PATCH v2 09/15] xfs: mount-api - add xfs_remount_rw() helper Ian Kent
2019-08-28 13:27   ` Brian Foster
2019-08-23  1:00 ` [PATCH v2 10/15] xfs: mount-api - add xfs_remount_ro() helper Ian Kent
2019-08-28 13:27   ` Brian Foster
2019-08-23  1:00 ` [PATCH v2 11/15] xfs: mount api - add xfs_reconfigure() Ian Kent
2019-08-28 13:28   ` Brian Foster
2019-08-30 11:10     ` Ian Kent
2019-08-30 11:56       ` Brian Foster
2019-09-02  2:41         ` Ian Kent
2019-08-23  1:00 ` [PATCH v2 12/15] xfs: mount-api - add xfs_fc_free() Ian Kent
2019-08-28 13:28   ` Brian Foster
2019-08-30 11:19     ` Ian Kent
2019-08-30 11:20     ` Ian Kent
2019-08-23  1:00 ` [PATCH v2 13/15] xfs: mount-api - dont set sb in xfs_mount_alloc() Ian Kent
2019-08-28 13:28   ` Brian Foster
2019-08-23  1:00 ` [PATCH v2 14/15] xfs: mount-api - switch to new mount-api Ian Kent
2019-08-28 13:29   ` Brian Foster
2019-08-28 13:34     ` Eric Sandeen
2019-08-30 11:30       ` Ian Kent
2019-08-30 11:27     ` Ian Kent
2019-08-23  1:00 ` [PATCH v2 15/15] xfs: mount-api - remove legacy mount functions Ian Kent
2019-08-26 19:33 ` [PATCH v2 00/15] xfs: mount API patch series Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156652199954.2607.8863934346265980917.stgit@fedora-28 \
    --to=raven@themaw.net \
    --cc=dchinner@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox