linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aliasgar Surti <aliasgar.surti500@gmail.com>
To: darrick.wong@oracle.com, linux-xfs@vger.kernel.org, bfoster@redhat.com
Cc: Aliasgar Surti <aliasgar.surti500@gmail.com>
Subject: [PATCH] xfs: removed unused error variable from xchk_refcountbt_rec
Date: Mon, 30 Sep 2019 19:28:54 +0530	[thread overview]
Message-ID: <1569851934-10718-1-git-send-email-aliasgar.surti500@gmail.com> (raw)

From: Aliasgar Surti <aliasgar.surti500@gmail.com>

Removed unused error variable. Instead of using error variable,
returned the value directly as it wasn't updated.

Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
---
 fs/xfs/scrub/refcount.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/xfs/scrub/refcount.c b/fs/xfs/scrub/refcount.c
index 93b3793b..0cab11a 100644
--- a/fs/xfs/scrub/refcount.c
+++ b/fs/xfs/scrub/refcount.c
@@ -341,7 +341,6 @@ xchk_refcountbt_rec(
 	xfs_extlen_t		len;
 	xfs_nlink_t		refcount;
 	bool			has_cowflag;
-	int			error = 0;
 
 	bno = be32_to_cpu(rec->refc.rc_startblock);
 	len = be32_to_cpu(rec->refc.rc_blockcount);
@@ -366,7 +365,7 @@ xchk_refcountbt_rec(
 
 	xchk_refcountbt_xref(bs->sc, bno, len, refcount);
 
-	return error;
+	return 0;
 }
 
 /* Make sure we have as many refc blocks as the rmap says. */
-- 
2.7.4


             reply	other threads:[~2019-09-30 13:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-30 13:58 Aliasgar Surti [this message]
2019-09-30 17:04 ` [PATCH] xfs: removed unused error variable from xchk_refcountbt_rec Brian Foster
2019-09-30 18:24 ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1569851934-10718-1-git-send-email-aliasgar.surti500@gmail.com \
    --to=aliasgar.surti500@gmail.com \
    --cc=bfoster@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).