linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: [PATCHSET v23.1 0/2] xfs: enhance btree key checking
Date: Sun, 02 Oct 2022 11:20:12 -0700	[thread overview]
Message-ID: <166473481246.1084112.5533985608121370791.stgit@magnolia> (raw)

Hi all,

This series addresses some deficiencies in btree key comparisons that I
noticed while testing online scrub.  The first fixes a bug in the rmap
key comparison that prevents the rmap scrubber from detecting rmap
records for file space allocations with mismatched attr/bmbt flags.
The second patch fixes the scrub btree block checker to ensure that the
keys in the parent block accurately represent the block.

If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.

This is an extraordinary way to destroy everything.  Enjoy!
Comments and questions are, as always, welcome.

--D

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=btree-key-enhancements

xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=btree-key-enhancements
---
 fs/xfs/libxfs/xfs_rmap_btree.c |   25 ++++++++++++++------
 fs/xfs/scrub/btree.c           |   49 +++++++++++++++++++++++++++++++++++++++-
 2 files changed, 65 insertions(+), 9 deletions(-)


             reply	other threads:[~2022-10-02 18:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-02 18:20 Darrick J. Wong [this message]
2022-10-02 18:20 ` [PATCH 1/2] xfs: fix rmap key comparison functions Darrick J. Wong
2022-11-01 23:40   ` Dave Chinner
2022-11-02 23:53     ` Darrick J. Wong
2022-10-02 18:20 ` [PATCH 2/2] xfs: check btree keys reflect the child block Darrick J. Wong
2022-11-01 23:41   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166473481246.1084112.5533985608121370791.stgit@magnolia \
    --to=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).