From: Chandan Babu R <chandanrlinux@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, darrick.wong@oracle.com, david@fromorbit.com
Subject: Re: [PATCH V2 01/10] xfs: Add helper for checking per-inode extent count overflow
Date: Mon, 17 Aug 2020 13:14:05 +0530 [thread overview]
Message-ID: <1668045.YsUOKkzclo@garuda> (raw)
In-Reply-To: <20200817065123.GA23516@infradead.org>
On Monday 17 August 2020 12:21:23 PM IST Christoph Hellwig wrote:
> > +int
> > +xfs_iext_count_may_overflow(
> > + struct xfs_inode *ip,
> > + int whichfork,
> > + int nr_to_add)
> > +{
> > + struct xfs_ifork *ifp;
> > + uint64_t max_exts = 0;
> > + uint64_t nr_exts;
> > +
> > + switch (whichfork) {
> > + case XFS_DATA_FORK:
> > + max_exts = MAXEXTNUM;
> > + break;
> > +
> > + case XFS_ATTR_FORK:
> > + max_exts = MAXAEXTNUM;
> > + break;
> > +
> > + default:
> > + ASSERT(0);
> > + break;
> > + }
> > +
> > + ifp = XFS_IFORK_PTR(ip, whichfork);
> > + nr_exts = ifp->if_nextents + nr_to_add;
> > +
> > + if (nr_exts > max_exts)
> > + return -EFBIG;
> > +
> > + return 0;
> > +}
>
> Maybe it's just me, but I would structure this very different (just
> cosmetic differences, though). First add a:
>
> static inline uint32_t xfs_max_extents(int whichfork)
> {
> return XFS_ATTR_FORK ? MAXAEXTNUM : MAXEXTNUM;
> }
>
> to have a single place that determines the max number of extents.
>
> And the simplify the helper down to:
>
> int
> xfs_iext_count_may_overflow(
> struct xfs_inode *ip,
> int whichfork,
> int nr_to_add)
> {
> struct xfs_ifork *ifp = XFS_IFORK_PTR(ip, whichfork);
> uint64_t max_exts = xfs_max_extents(whichfork);
> uint64_t nr_exts;
>
> if (check_add_overflow(ifp->if_nextents, nr_to_add, &nr_exts) ||
> nr_exts > max_exts))
> return -EFBIG;
> return 0;
> }
>
> which actually might be small enough for an inline function now.
>
I agree. I will make the suggested changes in the next version.
--
chandan
next prev parent reply other threads:[~2020-08-17 7:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 8:08 [PATCH V2 00/10] Bail out if transaction can cause extent count to overflow Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 01/10] xfs: Add helper for checking per-inode extent count overflow Chandan Babu R
2020-08-17 6:51 ` Christoph Hellwig
2020-08-17 7:44 ` Chandan Babu R [this message]
2020-08-14 8:08 ` [PATCH V2 02/10] xfs: Check for extent overflow when trivally adding a new extent Chandan Babu R
2020-08-17 6:53 ` Christoph Hellwig
2020-08-17 7:44 ` Chandan Babu R
2020-08-27 8:09 ` Christoph Hellwig
2020-08-27 13:51 ` Chandan Babu R
2020-08-18 21:49 ` Dave Chinner
2020-08-18 21:57 ` Darrick J. Wong
2020-08-19 4:43 ` Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 03/10] xfs: Check for extent overflow when deleting an extent Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 04/10] xfs: Check for extent overflow when adding/removing xattrs Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 05/10] xfs: Check for extent overflow when adding/removing dir entries Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 06/10] xfs: Check for extent overflow when writing to unwritten extent Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 07/10] xfs: Check for extent overflow when inserting a hole Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 08/10] xfs: Check for extent overflow when moving extent from cow to data fork Chandan Babu R
2020-08-18 22:03 ` Darrick J. Wong
2020-08-19 5:04 ` Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 09/10] xfs: Check for extent overflow when remapping an extent Chandan Babu R
2020-08-14 8:08 ` [PATCH V2 10/10] xfs: Check for extent overflow when swapping extents Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1668045.YsUOKkzclo@garuda \
--to=chandanrlinux@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox