Re: [PATCH 5/7] xfs: reuse xfs_bmap_update_cancel_item

Darrick J. Wong
2024-01-03T01:21:41Z

On Tue, Jan 02, 2024 at 02:45:11AM -0800, Christoph Hellwig wrote:
> On Sun, Dec 31, 2023 at 12:21:38PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Reuse xfs_bmap_update_cancel_item to put the AG/RTG and free the item in
> > a few places that currently open code the logic.
> >
> > Inspired-by: Christoph Hellwig <hch@lst.de>
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
>
> Isn't this actually pretty much exactly my patch?

Yeah, but with some non-trivial alterations, so that's why I went with
the tagset presented here.

> Either way this looks (obviously :)) good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!

--D