Re: [PATCHSET v29.0 34/40] xfs_scrub: fixes for systemd services

Neal Gompa
2023-12-31T20:26:20Z

On Sun, Dec 31, 2023 at 2:48 PM Darrick J. Wong <djwong@kernel.org> wrote:
>
> Hi all,
>
> This series fixes deficiencies in the systemd services that were created
> to manage background scans. First, improve the debian packaging so that
> services get installed at package install time. Next, fix copyright and
> spdx header omissions.
>
> Finally, fix bugs in the mailer scripts so that scrub failures are
> reported effectively. Finally, fix xfs_scrub_all to deal with systemd
> restarts causing it to think that a scrub has finished before the
> service actually finishes.
>
> If you're going to start using this code, I strongly recommend pulling
> from my git trees, which are linked below.
>
> This has been running on the djcloud for months with no problems. Enjoy!
> Comments and questions are, as always, welcome.
>
> --D
>
> xfsprogs git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=scrub-service-fixes
> ---
> debian/rules | 1 +
> include/builddefs.in | 2 +-
> scrub/Makefile | 26 ++++++++++++++------
> scrub/xfs_scrub@.service.in | 6 ++---
> scrub/xfs_scrub_all.in | 49 ++++++++++++++++----------------------
> scrub/xfs_scrub_fail.in | 12 ++++++++-
> scrub/xfs_scrub_fail@.service.in | 4 ++-
> 7 files changed, 55 insertions(+), 45 deletions(-)
> rename scrub/{xfs_scrub_fail => xfs_scrub_fail.in} (62%)
>

In your Makefile changes, you should be able to drop
PKG_LIB_SCRIPT_DIR entirely from your Makefiles since it should be
unused now, can you fold that into
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfsprogs-dev.git/commit/?h=scrub-service-fixes&id=1e0dce5c54270f1813f5661c266989917f08baf8
?

--
真実はいつも一つ！/ Always, there's only one truth!