Re: [PATCH 4/4] xfs: port refcount repair to the new refcount bag structure

Darrick J. Wong
2024-01-03T02:31:41Z

On Tue, Jan 02, 2024 at 02:43:47AM -0800, Christoph Hellwig wrote:
> On Sun, Dec 31, 2023 at 12:20:20PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Port the refcount record generating code to use the new refcount bag
> > data structure.
>
> This could again use some comments on why you're doing that. My strong
> suspicion is that it will be a lot faster and/or memory efficient, but
> please document this for future readers of the commit logs.

The new implementation is less memory efficient (because now we have
btree headers and internal nodes) but makes it a lot faster. If I turn
my reply to patch #2 into the commit message, will that work?

--D