* [PATCH] xfs: Remove deprecated xfs_bufd sysctl parameters
@ 2025-05-06 1:15 Zizhi Wo
2025-05-06 16:08 ` Darrick J. Wong
2025-05-09 11:43 ` Carlos Maiolino
0 siblings, 2 replies; 3+ messages in thread
From: Zizhi Wo @ 2025-05-06 1:15 UTC (permalink / raw)
To: chandan.babu, djwong, dchinner, osandov, john.g.garry
Cc: linux-xfs, linux-kernel, wozizhi, yangerkun, leo.lilong
From: Zizhi Wo <wozizhi@huawei.com>
Commit 64af7a6ea5a4 ("xfs: remove deprecated sysctls") removed the
deprecated xfsbufd-related sysctl interface, but forgot to delete the
corresponding parameters: "xfs_buf_timer" and "xfs_buf_age".
This patch removes those parameters and makes no other changes.
Signed-off-by: Zizhi Wo <wozizhi@huawei.com>
---
fs/xfs/xfs_globals.c | 2 --
fs/xfs/xfs_sysctl.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/fs/xfs/xfs_globals.c b/fs/xfs/xfs_globals.c
index f18fec0adf66..f6f628c01feb 100644
--- a/fs/xfs/xfs_globals.c
+++ b/fs/xfs/xfs_globals.c
@@ -23,8 +23,6 @@ xfs_param_t xfs_params = {
.inherit_sync = { 0, 1, 1 },
.inherit_nodump = { 0, 1, 1 },
.inherit_noatim = { 0, 1, 1 },
- .xfs_buf_timer = { 100/2, 1*100, 30*100 },
- .xfs_buf_age = { 1*100, 15*100, 7200*100},
.inherit_nosym = { 0, 0, 1 },
.rotorstep = { 1, 1, 255 },
.inherit_nodfrg = { 0, 1, 1 },
diff --git a/fs/xfs/xfs_sysctl.h b/fs/xfs/xfs_sysctl.h
index 276696a07040..51646f066c4f 100644
--- a/fs/xfs/xfs_sysctl.h
+++ b/fs/xfs/xfs_sysctl.h
@@ -29,8 +29,6 @@ typedef struct xfs_param {
xfs_sysctl_val_t inherit_sync; /* Inherit the "sync" inode flag. */
xfs_sysctl_val_t inherit_nodump;/* Inherit the "nodump" inode flag. */
xfs_sysctl_val_t inherit_noatim;/* Inherit the "noatime" inode flag. */
- xfs_sysctl_val_t xfs_buf_timer; /* Interval between xfsbufd wakeups. */
- xfs_sysctl_val_t xfs_buf_age; /* Metadata buffer age before flush. */
xfs_sysctl_val_t inherit_nosym; /* Inherit the "nosymlinks" flag. */
xfs_sysctl_val_t rotorstep; /* inode32 AG rotoring control knob */
xfs_sysctl_val_t inherit_nodfrg;/* Inherit the "nodefrag" inode flag. */
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: Remove deprecated xfs_bufd sysctl parameters
2025-05-06 1:15 [PATCH] xfs: Remove deprecated xfs_bufd sysctl parameters Zizhi Wo
@ 2025-05-06 16:08 ` Darrick J. Wong
2025-05-09 11:43 ` Carlos Maiolino
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2025-05-06 16:08 UTC (permalink / raw)
To: Zizhi Wo
Cc: chandan.babu, dchinner, osandov, john.g.garry, linux-xfs,
linux-kernel, wozizhi, yangerkun, leo.lilong
On Tue, May 06, 2025 at 09:15:40AM +0800, Zizhi Wo wrote:
> From: Zizhi Wo <wozizhi@huawei.com>
>
> Commit 64af7a6ea5a4 ("xfs: remove deprecated sysctls") removed the
> deprecated xfsbufd-related sysctl interface, but forgot to delete the
> corresponding parameters: "xfs_buf_timer" and "xfs_buf_age".
>
> This patch removes those parameters and makes no other changes.
>
> Signed-off-by: Zizhi Wo <wozizhi@huawei.com>
Heh, yep, those aren't in use anywhere.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_globals.c | 2 --
> fs/xfs/xfs_sysctl.h | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_globals.c b/fs/xfs/xfs_globals.c
> index f18fec0adf66..f6f628c01feb 100644
> --- a/fs/xfs/xfs_globals.c
> +++ b/fs/xfs/xfs_globals.c
> @@ -23,8 +23,6 @@ xfs_param_t xfs_params = {
> .inherit_sync = { 0, 1, 1 },
> .inherit_nodump = { 0, 1, 1 },
> .inherit_noatim = { 0, 1, 1 },
> - .xfs_buf_timer = { 100/2, 1*100, 30*100 },
> - .xfs_buf_age = { 1*100, 15*100, 7200*100},
> .inherit_nosym = { 0, 0, 1 },
> .rotorstep = { 1, 1, 255 },
> .inherit_nodfrg = { 0, 1, 1 },
> diff --git a/fs/xfs/xfs_sysctl.h b/fs/xfs/xfs_sysctl.h
> index 276696a07040..51646f066c4f 100644
> --- a/fs/xfs/xfs_sysctl.h
> +++ b/fs/xfs/xfs_sysctl.h
> @@ -29,8 +29,6 @@ typedef struct xfs_param {
> xfs_sysctl_val_t inherit_sync; /* Inherit the "sync" inode flag. */
> xfs_sysctl_val_t inherit_nodump;/* Inherit the "nodump" inode flag. */
> xfs_sysctl_val_t inherit_noatim;/* Inherit the "noatime" inode flag. */
> - xfs_sysctl_val_t xfs_buf_timer; /* Interval between xfsbufd wakeups. */
> - xfs_sysctl_val_t xfs_buf_age; /* Metadata buffer age before flush. */
> xfs_sysctl_val_t inherit_nosym; /* Inherit the "nosymlinks" flag. */
> xfs_sysctl_val_t rotorstep; /* inode32 AG rotoring control knob */
> xfs_sysctl_val_t inherit_nodfrg;/* Inherit the "nodefrag" inode flag. */
> --
> 2.39.2
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: Remove deprecated xfs_bufd sysctl parameters
2025-05-06 1:15 [PATCH] xfs: Remove deprecated xfs_bufd sysctl parameters Zizhi Wo
2025-05-06 16:08 ` Darrick J. Wong
@ 2025-05-09 11:43 ` Carlos Maiolino
1 sibling, 0 replies; 3+ messages in thread
From: Carlos Maiolino @ 2025-05-09 11:43 UTC (permalink / raw)
To: chandan.babu, djwong, dchinner, osandov, john.g.garry, Zizhi Wo
Cc: linux-xfs, linux-kernel, wozizhi, yangerkun, leo.lilong
On Tue, 06 May 2025 09:15:40 +0800, Zizhi Wo wrote:
> Commit 64af7a6ea5a4 ("xfs: remove deprecated sysctls") removed the
> deprecated xfsbufd-related sysctl interface, but forgot to delete the
> corresponding parameters: "xfs_buf_timer" and "xfs_buf_age".
>
> This patch removes those parameters and makes no other changes.
>
>
> [...]
Applied to for-next, thanks!
[1/1] xfs: Remove deprecated xfs_bufd sysctl parameters
commit: 92926c447c606dcf2fb6d0c3e32491775f4eb123
Best regards,
--
Carlos Maiolino <cem@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-09 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-06 1:15 [PATCH] xfs: Remove deprecated xfs_bufd sysctl parameters Zizhi Wo
2025-05-06 16:08 ` Darrick J. Wong
2025-05-09 11:43 ` Carlos Maiolino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).