From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, aalbersh@kernel.org
Cc: catherine.hoang@oracle.com, john.g.garry@oracle.com,
linux-xfs@vger.kernel.org
Subject: [PATCH 2/7] xfs_db: create an untorn_max subcommand
Date: Tue, 01 Jul 2025 11:07:28 -0700 [thread overview]
Message-ID: <175139303875.916168.18071503400698892291.stgit@frogsfrogsfrogs> (raw)
In-Reply-To: <175139303809.916168.13664699895415552120.stgit@frogsfrogsfrogs>
From: Darrick J. Wong <djwong@kernel.org>
Create a debugger command to compute the either the logres needed to
perform an untorn cow write completion for a given number of blocks; or
the number of blocks that can be completed given a log reservation.
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
include/libxfs.h | 1
libxfs/libxfs_api_defs.h | 4 +
db/logformat.c | 129 ++++++++++++++++++++++++++++++++++++++++++++++
man/man8/xfs_db.8 | 10 ++++
4 files changed, 144 insertions(+)
diff --git a/include/libxfs.h b/include/libxfs.h
index b968a2b88da372..1e0d1a48fbb698 100644
--- a/include/libxfs.h
+++ b/include/libxfs.h
@@ -102,6 +102,7 @@ struct iomap;
#include "xfs_rtbitmap.h"
#include "xfs_rtrmap_btree.h"
#include "xfs_ag_resv.h"
+#include "defer_item.h"
#ifndef ARRAY_SIZE
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
diff --git a/libxfs/libxfs_api_defs.h b/libxfs/libxfs_api_defs.h
index c5fcb5e3229ae4..4bd02c57b496e6 100644
--- a/libxfs/libxfs_api_defs.h
+++ b/libxfs/libxfs_api_defs.h
@@ -108,6 +108,10 @@
#define xfs_bunmapi libxfs_bunmapi
#define xfs_bwrite libxfs_bwrite
#define xfs_calc_dquots_per_chunk libxfs_calc_dquots_per_chunk
+#define xfs_calc_finish_bui_reservation libxfs_calc_finish_bui_reservation
+#define xfs_calc_finish_cui_reservation libxfs_calc_finish_cui_reservation
+#define xfs_calc_finish_efi_reservation libxfs_calc_finish_efi_reservation
+#define xfs_calc_finish_rui_reservation libxfs_calc_finish_rui_reservation
#define xfs_cntbt_init_cursor libxfs_cntbt_init_cursor
#define xfs_compute_rextslog libxfs_compute_rextslog
#define xfs_compute_rgblklog libxfs_compute_rgblklog
diff --git a/db/logformat.c b/db/logformat.c
index 5edaa5494637c8..454ea20c0c7d5c 100644
--- a/db/logformat.c
+++ b/db/logformat.c
@@ -192,8 +192,137 @@ static const struct cmdinfo logres_cmd = {
.help = logres_help,
};
+STATIC void
+untorn_cow_limits(
+ struct xfs_mount *mp,
+ unsigned int logres,
+ unsigned int desired_max)
+{
+ const unsigned int efi = xfs_efi_log_space(1);
+ const unsigned int efd = xfs_efd_log_space(1);
+ const unsigned int rui = xfs_rui_log_space(1);
+ const unsigned int rud = xfs_rud_log_space();
+ const unsigned int cui = xfs_cui_log_space(1);
+ const unsigned int cud = xfs_cud_log_space();
+ const unsigned int bui = xfs_bui_log_space(1);
+ const unsigned int bud = xfs_bud_log_space();
+
+ /*
+ * Maximum overhead to complete an untorn write ioend in software:
+ * remove data fork extent + remove cow fork extent + map extent into
+ * data fork.
+ *
+ * tx0: Creates a BUI and a CUI and that's all it needs.
+ *
+ * tx1: Roll to finish the BUI. Need space for the BUD, an RUI, and
+ * enough space to relog the CUI (== CUI + CUD).
+ *
+ * tx2: Roll again to finish the RUI. Need space for the RUD and space
+ * to relog the CUI.
+ *
+ * tx3: Roll again, need space for the CUD and possibly a new EFI.
+ *
+ * tx4: Roll again, need space for an EFD.
+ *
+ * If the extent referenced by the pair of BUI/CUI items is not the one
+ * being currently processed, then we need to reserve space to relog
+ * both items.
+ */
+ const unsigned int tx0 = bui + cui;
+ const unsigned int tx1 = bud + rui + cui + cud;
+ const unsigned int tx2 = rud + cui + cud;
+ const unsigned int tx3 = cud + efi;
+ const unsigned int tx4 = efd;
+ const unsigned int relog = bui + bud + cui + cud;
+
+ const unsigned int per_intent = max(max3(tx0, tx1, tx2),
+ max3(tx3, tx4, relog));
+
+ /* Overhead to finish one step of each intent item type */
+ const unsigned int f1 = libxfs_calc_finish_efi_reservation(mp, 1);
+ const unsigned int f2 = libxfs_calc_finish_rui_reservation(mp, 1);
+ const unsigned int f3 = libxfs_calc_finish_cui_reservation(mp, 1);
+ const unsigned int f4 = libxfs_calc_finish_bui_reservation(mp, 1);
+
+ /* We only finish one item per transaction in a chain */
+ const unsigned int step_size = max(f4, max3(f1, f2, f3));
+
+ if (desired_max) {
+ dbprintf(
+ "desired_max: %u\nstep_size: %u\nper_intent: %u\nlogres: %u\n",
+ desired_max, step_size, per_intent,
+ (desired_max * per_intent) + step_size);
+ } else if (logres) {
+ dbprintf(
+ "logres: %u\nstep_size: %u\nper_intent: %u\nmax_awu: %u\n",
+ logres, step_size, per_intent,
+ logres >= step_size ? (logres - step_size) / per_intent : 0);
+ }
+}
+
+static void
+untorn_max_help(void)
+{
+ dbprintf(_(
+"\n"
+" The 'untorn_max' command computes either the log reservation needed to\n"
+" complete an untorn write of a given block count; or the maximum number of\n"
+" blocks that can be completed given a specific log reservation.\n"
+"\n"
+ ));
+}
+
+static int
+untorn_max_f(
+ int argc,
+ char **argv)
+{
+ unsigned int logres = 0;
+ unsigned int desired_max = 0;
+ int c;
+
+ while ((c = getopt(argc, argv, "l:b:")) != EOF) {
+ switch (c) {
+ case 'l':
+ logres = atoi(optarg);
+ break;
+ case 'b':
+ desired_max = atoi(optarg);
+ break;
+ default:
+ untorn_max_help();
+ return 0;
+ }
+ }
+
+ if (!logres && !desired_max) {
+ dbprintf("untorn_max needs -l or -b option\n");
+ return 0;
+ }
+
+ if (xfs_has_reflink(mp))
+ untorn_cow_limits(mp, logres, desired_max);
+ else
+ dbprintf("untorn write emulation not supported\n");
+
+ return 0;
+}
+
+static const struct cmdinfo untorn_max_cmd = {
+ .name = "untorn_max",
+ .altname = NULL,
+ .cfunc = untorn_max_f,
+ .argmin = 0,
+ .argmax = -1,
+ .canpush = 0,
+ .args = NULL,
+ .oneline = N_("compute untorn write max"),
+ .help = logres_help,
+};
+
void
logres_init(void)
{
add_command(&logres_cmd);
+ add_command(&untorn_max_cmd);
}
diff --git a/man/man8/xfs_db.8 b/man/man8/xfs_db.8
index 2a9322560584b0..d4531fc0e380a3 100644
--- a/man/man8/xfs_db.8
+++ b/man/man8/xfs_db.8
@@ -1366,6 +1366,16 @@ .SH COMMANDS
.IR name .
The file being targetted will not be put on the iunlink list.
.TP
+.BI "untorn_max [\-b " blockcount "|\-l " logres "]"
+If
+.B -l
+is specified, compute the maximum (in fsblocks) untorn write that we can
+emulate with copy on write given a log reservation size (in bytes).
+If
+.B -b
+is specified, compute the log reservation size that would be needed to
+emulate an untorn write of the given number of fsblocks.
+.TP
.BI "uuid [" uuid " | " generate " | " rewrite " | " restore ]
Set the filesystem universally unique identifier (UUID).
The filesystem UUID can be used by
next prev parent reply other threads:[~2025-07-01 18:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 18:03 [PATCHBOMB] xfsprogs: ports and new code for 6.16 Darrick J. Wong
2025-07-01 18:04 ` [PATCHSET 1/3] xfsprogs: new libxfs code from kernel 6.16 Darrick J. Wong
2025-07-01 18:05 ` [PATCH 1/6] xfs: add helpers to compute transaction reservation for finishing intent items Darrick J. Wong
2025-07-01 18:05 ` [PATCH 2/6] xfs: allow block allocator to take an alignment hint Darrick J. Wong
2025-07-01 18:06 ` [PATCH 3/6] xfs: commit CoW-based atomic writes atomically Darrick J. Wong
2025-07-01 18:06 ` [PATCH 4/6] libxfs: add helpers to compute log item overhead Darrick J. Wong
2025-07-01 18:06 ` [PATCH 5/6] xfs: add xfs_calc_atomic_write_unit_max() Darrick J. Wong
2025-07-01 18:06 ` [PATCH 6/6] xfs: allow sysadmins to specify a maximum atomic write limit at mount time Darrick J. Wong
2025-07-01 18:05 ` [PATCHSET 2/3] xfsprogs: atomic writes Darrick J. Wong
2025-07-01 18:07 ` [PATCH 1/7] libfrog: move statx.h from io/ to libfrog/ Darrick J. Wong
2025-07-02 9:13 ` John Garry
2025-07-01 18:07 ` Darrick J. Wong [this message]
2025-07-09 15:39 ` [PATCH 2/7] xfs_db: create an untorn_max subcommand John Garry
2025-07-09 16:35 ` Darrick J. Wong
2025-07-01 18:07 ` [PATCH 3/7] xfs_io: dump new atomic_write_unit_max_opt statx field Darrick J. Wong
2025-07-02 8:23 ` John Garry
2025-07-01 18:07 ` [PATCH 4/7] mkfs: don't complain about overly large auto-detected log stripe units Darrick J. Wong
2025-07-08 14:38 ` John Garry
2025-07-08 15:05 ` Darrick J. Wong
2025-07-08 15:07 ` John Garry
2025-07-01 18:08 ` [PATCH 5/7] mkfs: autodetect log stripe unit for external log devices Darrick J. Wong
2025-07-09 15:57 ` John Garry
2025-07-09 16:45 ` Darrick J. Wong
2025-07-01 18:08 ` [PATCH 6/7] mkfs: try to align AG size based on atomic write capabilities Darrick J. Wong
2025-07-02 9:03 ` John Garry
2025-07-02 19:00 ` Darrick J. Wong
2025-07-01 18:08 ` [PATCH 7/7] mkfs: allow users to configure the desired maximum atomic write size Darrick J. Wong
2025-07-02 8:50 ` John Garry
2025-07-02 19:01 ` Darrick J. Wong
2025-07-01 18:05 ` [PATCHSET 3/3] xfs_scrub: drop EXPERIMENTAL warning Darrick J. Wong
2025-07-01 18:09 ` [PATCH 1/1] xfs_scrub: remove EXPERIMENTAL warnings Darrick J. Wong
2025-07-03 13:45 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2025-07-15 5:16 [PATCHSET 2/3] xfsprogs: atomic writes Darrick J. Wong
2025-07-15 5:18 ` [PATCH 2/7] xfs_db: create an untorn_max subcommand Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175139303875.916168.18071503400698892291.stgit@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=john.g.garry@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox