From: Carlos Maiolino <cem@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: cleanup log item formatting v3
Date: Mon, 24 Nov 2025 16:05:54 +0100 [thread overview]
Message-ID: <176399675437.124952.10369985473910554845.b4-ty@kernel.org> (raw)
In-Reply-To: <20251112121458.915383-1-hch@lst.de>
On Wed, 12 Nov 2025 13:14:16 +0100, Christoph Hellwig wrote:
> I dug into a rabit hole about the log item formatting recently,
> and noticed that the handling of the opheaders is still pretty
> ugly because it leaks pre-delayed logging implementation
> details into the log item implementations.
>
> The core of this series is to remove the to reserve space in the
> CIL buffers/shadow buffers for the opheaders that already were
> generated more or less on the fly by the lowlevel log write
> code anyway, but there's lots of other cleanups around it.
>
> [...]
Applied to for-next, thanks!
[01/10] xfs: add a xlog_write_one_vec helper
commit: 5a231381e5e83d266e2d9ba66d1d7f0a9aff3e88
[02/10] xfs: set lv_bytes in xlog_write_one_vec
commit: 74f645212e0dbfe8c7614b4ba0946f1198148fec
[03/10] xfs: improve the ->iop_format interface
commit: 406fa5a5a9c303c55924601c8a8ab9aa0228e084
[04/10] xfs: move struct xfs_log_iovec to xfs_log_priv.h
commit: d09aeba6ce6e8d98eb14207a24ae2c6e01c6065e
[05/10] xfs: move struct xfs_log_vec to xfs_log_priv.h
commit: 9ff5678846f2a818c744728c3ab58d77b35e07e7
[06/10] xfs: regularize iclog space accounting in xlog_write_partial
commit: 4d139d3aebef74de9eeb1a24ae35f20f1665c919
[07/10] xfs: improve the calling convention for the xlog_write helpers
commit: c11b2834d0b2fe3da7c024fe0a840fd953b56b62
[08/10] xfs: add a xlog_write_space_left helper
commit: 4eb6609e629b2e7af1d22f0d66c6ccf9c3faceeb
[09/10] xfs: improve the iclog space assert in xlog_write_iovec
commit: 9c3fead7ccd4bc5e6c30f9d8218a1440ec31687c
[10/10] xfs: factor out a xlog_write_space_advance helper
commit: f66ea030a78345fabeb8604cbf2a7132b25d30fa
Best regards,
--
Carlos Maiolino <cem@kernel.org>
prev parent reply other threads:[~2025-11-24 15:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 12:14 cleanup log item formatting v3 Christoph Hellwig
2025-11-12 12:14 ` [PATCH 01/10] xfs: add a xlog_write_one_vec helper Christoph Hellwig
2025-11-12 12:14 ` [PATCH 02/10] xfs: set lv_bytes in xlog_write_one_vec Christoph Hellwig
2025-11-14 16:55 ` Darrick J. Wong
2025-11-12 12:14 ` [PATCH 03/10] xfs: improve the ->iop_format interface Christoph Hellwig
2025-11-12 12:14 ` [PATCH 04/10] xfs: move struct xfs_log_iovec to xfs_log_priv.h Christoph Hellwig
2025-11-12 12:14 ` [PATCH 05/10] xfs: move struct xfs_log_vec " Christoph Hellwig
2025-11-12 12:14 ` [PATCH 06/10] xfs: regularize iclog space accounting in xlog_write_partial Christoph Hellwig
2025-11-14 16:55 ` Darrick J. Wong
2025-11-12 12:14 ` [PATCH 07/10] xfs: improve the calling convention for the xlog_write helpers Christoph Hellwig
2025-11-14 16:56 ` Darrick J. Wong
2025-11-12 12:14 ` [PATCH 08/10] xfs: add a xlog_write_space_left helper Christoph Hellwig
2025-11-12 12:14 ` [PATCH 09/10] xfs: improve the iclog space assert in xlog_write_iovec Christoph Hellwig
2025-11-12 12:14 ` [PATCH 10/10] xfs: factor out a xlog_write_space_advance helper Christoph Hellwig
2025-11-24 15:05 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176399675437.124952.10369985473910554845.b4-ty@kernel.org \
--to=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).