public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Carlos Maiolino <cem@kernel.org>
To: linux-xfs@vger.kernel.org, Brian Foster <bfoster@redhat.com>
Cc: stable@vger.kernel.org, "Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH v2] xfs: set max_agbno to allow sparse alloc of last full inode chunk
Date: Tue, 13 Jan 2026 14:10:42 +0100	[thread overview]
Message-ID: <176830984207.127908.986837300693754685.b4-ty@kernel.org> (raw)
In-Reply-To: <20260109174905.26372-1-bfoster@redhat.com>

On Fri, 09 Jan 2026 12:49:05 -0500, Brian Foster wrote:
> Sparse inode cluster allocation sets min/max agbno values to avoid
> allocating an inode cluster that might map to an invalid inode
> chunk. For example, we can't have an inode record mapped to agbno 0
> or that extends past the end of a runt AG of misaligned size.
> 
> The initial calculation of max_agbno is unnecessarily conservative,
> however. This has triggered a corner case allocation failure where a
> small runt AG (i.e. 2063 blocks) is mostly full save for an extent
> to the EOFS boundary: [2050,13]. max_agbno is set to 2048 in this
> case, which happens to be the offset of the last possible valid
> inode chunk in the AG. In practice, we should be able to allocate
> the 4-block cluster at agbno 2052 to map to the parent inode record
> at agbno 2048, but the max_agbno value precludes it.
> 
> [...]

Applied to for-next, thanks!

[1/1] xfs: set max_agbno to allow sparse alloc of last full inode chunk
      commit: c360004c0160dbe345870f59f24595519008926f

Best regards,
-- 
Carlos Maiolino <cem@kernel.org>


      reply	other threads:[~2026-01-13 13:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09 17:49 [PATCH v2] xfs: set max_agbno to allow sparse alloc of last full inode chunk Brian Foster
2026-01-13 13:10 ` Carlos Maiolino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176830984207.127908.986837300693754685.b4-ty@kernel.org \
    --to=cem@kernel.org \
    --cc=bfoster@redhat.com \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox