From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA9773F8890; Tue, 7 Jul 2026 11:37:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783424255; cv=none; b=i1XJo2m4chpWQaIi8qYW6Iwq8S7d7qyBW0SkTM460VvnMXTTUiZ0XYPqT5bPNQP0VTgCLzu6TBt003bpeMNoyb0ftOcNIRPN/X4Zr41nnlHQPYdqre+yh4U9pTQBRZIo0MUkd8R600jCED6juS7I/30pdjFVivfx1a+HuPWtdI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783424255; c=relaxed/simple; bh=PUo+3K0Q1NJfep5hQqfQlWTmat/wLFDSiUbXhXpAano=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=hZMzSDKwXethSaYLGfScBbCxFLk/cux02DM/LbyW+3e7+KU0/5FY+e3v4q/+vud1YA5n5FlVO5OKdkaG2UxZ/TLuvELjE4bH8lO/zsQ9CTzRPc6ddlYS6ul/h2knMN6E+hRNNXP3jfon7uhMpHeaMyKgSzeYvcWs/VN+I4OgjWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cLE9+oCb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cLE9+oCb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 412761F00A3A; Tue, 7 Jul 2026 11:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783424254; bh=+k86CLm+gnkbII2jSjaE+dGWoQpJrqTR4ETI0quIwtI=; h=From:To:Cc:In-Reply-To:References:Subject:Date; b=cLE9+oCbezyPcC0+8Heu2Ji1XNFSW4st9sTnw7G3A88T1ysFPI0e/sv0SpJXxRuy0 BtDrhBUgWV2jsaAjpTd2bofRkxJxcOQcL0tUHwE0rAxzdqgxtk/lBdYUYPo1xqnJuU jen/H8h6wPfCSqqviHwTCJ1z78TwDdBv4LjrWCjndx5M5axT8rpeiAxImy1VpSHIEe 5dDZ4edPgpZdFSs4HRhnrDssI3/VOW1iOD7YaL0cu2YHyzs+d2yRq7gxgSYoez4k0F vQ19RzZMH1yU3Y7G1R6rh4drg4bbFb3/BNm1PQLd1PRRne+bOlo2xfwBKkcwugDz2I ldJhaq/8vytdw== From: Carlos Maiolino To: linux-xfs@vger.kernel.org, Weiming Shi Cc: "Darrick J . Wong" , Brian Foster , Christoph Hellwig , Xiang Mei , stable@vger.kernel.org In-Reply-To: <20260702162000.3548359-4-bestswngs@gmail.com> References: <20260702162000.3548359-4-bestswngs@gmail.com> Subject: Re: [PATCH v3] xfs: fail recovery on a committed log item with no regions Message-Id: <178342425298.389943.1711934889930818397.b4-ty@b4> Date: Tue, 07 Jul 2026 13:37:32 +0200 Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.15.2 On Thu, 02 Jul 2026 09:20:00 -0700, Weiming Shi wrote: > If the first op of a transaction is a bare transaction header > (len == sizeof(struct xfs_trans_header)), xlog_recover_add_to_trans() > adds an item but no region, leaving it on r_itemq with ri_cnt == 0 and > ri_buf == NULL. > > The header can be split across op records, so later ops may still add > regions; the item is only invalid if the transaction commits with none. > The runtime commit path never emits such a transaction, so this only > happens on a crafted log. It came from an AI-assisted code audit of the > recovery parser. > > [...] Applied to for-next, thanks! [1/1] xfs: fail recovery on a committed log item with no regions commit: 92d2d133c6cb38582fd52e6fa903ff0b6a00918e Best regards, -- Carlos Maiolino