From: John Garry <john.g.garry@oracle.com>
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>,
Zorro Lang <zlang@redhat.com>,
fstests@vger.kernel.org
Cc: Ritesh Harjani <ritesh.list@gmail.com>,
djwong@kernel.org, tytso@mit.edu, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v5 05/12] generic: Add atomic write test using fio crc check verifier
Date: Tue, 2 Sep 2025 16:09:23 +0100 [thread overview]
Message-ID: <184e4080-ff02-4d75-be35-ab49f61dbd3d@oracle.com> (raw)
In-Reply-To: <90241ec96d84e6e87d8cf8bd0d0d75fcc296757c.1755849134.git.ojaswin@linux.ibm.com>
On 22/08/2025 09:02, Ojaswin Mujoo wrote:
> This adds atomic write test using fio based on it's crc check verifier.
> fio adds a crc header for each data block, which is verified later to
> ensure there is no data corruption or torn write.
>
> This test essentially does a lot of parallel RWF_ATOMIC IO on a
> preallocated file to stress the write and end-io unwritten conversion
> code paths. The idea is to increase code coverage to ensure RWF_ATOMIC
> hasn't introduced any issues.
>
> Avoid doing overlapping parallel atomic writes because it might give
> unexpected results. Use offset_increment=, size= fio options to achieve
> this behavior.
>
> Co-developed-by: Ritesh Harjani (IBM)<ritesh.list@gmail.com>
> Signed-off-by: Ritesh Harjani (IBM)<ritesh.list@gmail.com>
> Reviewed-by: Darrick J. Wong<djwong@kernel.org>
> Signed-off-by: Ojaswin Mujoo<ojaswin@linux.ibm.com>
I am still a bit skeptical of the value of this test, but here is my tag
anyway:
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2025-09-02 15:09 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 8:01 [PATCH v5 00/11] Add more tests for multi fs block atomic writes Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 01/12] common/rc: Add _min() and _max() helpers Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 02/12] common/rc: Add _require_fio_version helper Ojaswin Mujoo
2025-08-25 16:08 ` Zorro Lang
2025-08-27 15:16 ` Ojaswin Mujoo
2025-08-28 15:09 ` Darrick J. Wong
2025-08-29 16:59 ` Ojaswin Mujoo
2025-08-30 17:09 ` Zorro Lang
2025-09-01 11:40 ` Ojaswin Mujoo
2025-09-02 5:30 ` Zorro Lang
2025-09-02 8:29 ` John Garry
2025-09-02 14:50 ` John Garry
2025-09-05 15:51 ` Ojaswin Mujoo
2025-09-05 16:14 ` John Garry
2025-09-05 16:39 ` Ojaswin Mujoo
2025-09-07 5:18 ` Zorro Lang
2025-09-07 5:29 ` Zorro Lang
2025-08-22 8:02 ` [PATCH v5 03/12] common/rc: Add a helper to run fsx on a given file Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 04/12] ltp/fsx.c: Add atomic writes support to fsx Ojaswin Mujoo
2025-09-02 15:06 ` John Garry
2025-09-05 16:29 ` Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 05/12] generic: Add atomic write test using fio crc check verifier Ojaswin Mujoo
2025-09-02 15:09 ` John Garry [this message]
2025-08-22 8:02 ` [PATCH v5 06/12] generic: Add atomic write test using fio verify on file mixed mappings Ojaswin Mujoo
2025-09-02 15:10 ` John Garry
2025-08-22 8:02 ` [PATCH v5 07/12] generic: Add atomic write multi-fsblock O_[D]SYNC tests Ojaswin Mujoo
2025-09-02 15:14 ` John Garry
2025-09-05 16:30 ` Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 08/12] generic: Stress fsx with atomic writes enabled Ojaswin Mujoo
2025-09-02 15:18 ` John Garry
2025-09-05 16:40 ` Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 09/12] generic: Add sudden shutdown tests for multi block atomic writes Ojaswin Mujoo
2025-09-02 15:49 ` John Garry
2025-09-05 17:06 ` Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 10/12] ext4: test atomic write and ioend codepaths with bigalloc Ojaswin Mujoo
2025-08-28 15:09 ` Darrick J. Wong
2025-09-02 15:52 ` John Garry
2025-08-22 8:02 ` [PATCH v5 11/12] ext4: Test atomic writes allocation and write " Ojaswin Mujoo
2025-09-02 15:54 ` John Garry
2025-09-05 17:10 ` Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 12/12] ext4: Atomic write test for extent split across leaf nodes Ojaswin Mujoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=184e4080-ff02-4d75-be35-ab49f61dbd3d@oracle.com \
--to=john.g.garry@oracle.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).