Re: [PATCH 22/28] xfs: refactor adding recovered intent items to the log

Christoph Hellwig
2020-05-06T15:31:12Z

On Mon, May 04, 2020 at 06:12:53PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> During recovery, every intent that we recover from the log has to be
> added to the AIL. Replace the open-coded addition with a helper.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Second thoughts: given that the helper is totally generic, maybe
name it xfs_trans_ail_insert and keep it in the generic AIL code?