Re: [PATCH 19/28] xfs: refactor xlog_recover_process_unlinked

Christoph Hellwig
2020-05-06T15:27:11Z

On Mon, May 04, 2020 at 06:12:35PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Hoist the unlinked inode processing logic out of the AG loop and into
> its own function. No functional changes.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_unlink_recover.c | 91 +++++++++++++++++++++++++------------------
> 1 file changed, 52 insertions(+), 39 deletions(-)
>
>
> diff --git a/fs/xfs/xfs_unlink_recover.c b/fs/xfs/xfs_unlink_recover.c
> index 2a19d096e88d..413b34085640 100644
> --- a/fs/xfs/xfs_unlink_recover.c
> +++ b/fs/xfs/xfs_unlink_recover.c
> @@ -145,54 +145,67 @@ xlog_recover_process_one_iunlink(
> * scheduled on this CPU to ensure other scheduled work can run without undue
> * latency.
> */
> -void
> -xlog_recover_process_unlinked(
> - struct xlog *log)
> +STATIC int
> +xlog_recover_process_iunlinked(

xlog_recover_process_ag_iunlinked?