Re: [PATCH 13/28] xfs: remove log recovery quotaoff item dispatch for pass2 commit functions

Darrick J. Wong
2020-05-06T16:50:51Z

On Wed, May 06, 2020 at 08:16:11AM -0700, Christoph Hellwig wrote:
> > diff --git a/fs/xfs/xfs_dquot_item_recover.c b/fs/xfs/xfs_dquot_item_recover.c
> > index 07ff943972a3..a07c1c8344d8 100644
> > --- a/fs/xfs/xfs_dquot_item_recover.c
> > +++ b/fs/xfs/xfs_dquot_item_recover.c
> > @@ -197,4 +197,5 @@ xlog_recover_quotaoff_commit_pass1(
> > const struct xlog_recover_item_ops xlog_quotaoff_item_ops = {
> > .item_type = XFS_LI_QUOTAOFF,
> > .commit_pass1 = xlog_recover_quotaoff_commit_pass1,
> > + .commit_pass2 = NULL, /* nothing to do in pass2 */
>
> No need to initialize 0 or NULL fields in static structures.

Ok, I'll trim this line to only have the comment, to make it explicit
that quotaoff does no work for commit_pass2.

--D

> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>