From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB949C4743E for ; Tue, 8 Jun 2021 17:26:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB65161029 for ; Tue, 8 Jun 2021 17:26:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231983AbhFHR20 (ORCPT ); Tue, 8 Jun 2021 13:28:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:58166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231416AbhFHR20 (ORCPT ); Tue, 8 Jun 2021 13:28:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 752536136D; Tue, 8 Jun 2021 17:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623173193; bh=quLPk8hf1rTsI/xDu+n2XJpKuLPzI5budPumpjnNExg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=BzsBwSngPLULxxPD6oB4tsxncLu2Xc8OBaztzdTDKmYZZ5qr1mDI/jNZWGmEW3ynD N4YKqlrlp1/SxNQ2ppnMpRDsl6tIfj18eHsqKOvbuxIa8CrC2takPVQ0yqFfiUO/ls AJhV/UxK5syg4kFKzNGeEdAfxQW6elZBw46CRkAKlg+mumbkoyF9XQGa/H6jOLrZTa BNazLU1YGSeTLVDuLsCTt7vKyMqEs6CovHtqujL7UjMucc23T6hLCbTtFTRtwGzZdZ lpPCIrReBi+xIXYuBUZPXo8WFDfH4Y8RTQyvQ6VOIDDzcOBidx3A/slQvjQw+ufFyh 9e0vUf1WLgbBQ== Subject: Re: [PATCH RFC] x86: remove toolchain check for X32 ABI capability To: Masahiro Yamada Cc: X86 ML , Thomas Gleixner , Borislav Petkov , "H . Peter Anvin" , Peter Zijlstra , Fangrui Song , clang-built-linux , "H . J . Lu" , Andy Lutomirski , Arnd Bergmann , Brian Gerst , "Chang S. Bae" , Chao Yu , "Darrick J. Wong" , Dmitry Safonov <0x7f454c46@gmail.com>, Dominik Brodowski , Gabriel Krisman Bertazi , Ingo Molnar , Jaroslav Kysela , Jason Gunthorpe , Jethro Beekman , Kees Cook , Miklos Szeredi , Nick Desaulniers , Sasha Levin , Sean Christopherson , Takashi Iwai , ALSA Development Mailing List , Linux FS-devel Mailing List , Linux Kernel Mailing List , linux-xfs References: <20210227183910.221873-1-masahiroy@kernel.org> <20210228064936.zixrhxlthyy6fmid@24bbad8f3778> From: Nathan Chancellor Message-ID: <1992c9cf-739e-d98f-85c0-bbcf7df123ea@kernel.org> Date: Tue, 8 Jun 2021 10:26:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org Hi Masahiro, On 6/7/2021 12:39 AM, Masahiro Yamada wrote: > On Sun, Feb 28, 2021 at 3:49 PM Nathan Chancellor wrote: >> >> On Sun, Feb 28, 2021 at 12:15:16PM +0900, Masahiro Yamada wrote: >>> On Sun, Feb 28, 2021 at 3:41 AM Masahiro Yamada wrote: >>>> >>>> This commit reverts 0bf6276392e9 ("x32: Warn and disable rather than >>>> error if binutils too old"). >>>> >>>> The help text in arch/x86/Kconfig says enabling the X32 ABI support >>>> needs binutils 2.22 or later. This is met because the minimal binutils >>>> version is 2.23 according to Documentation/process/changes.rst. >>>> >>>> I would not say I am not familiar with toolchain configuration, but >>> >>> I mean: >>> I would not say I am familiar ... >>> That is why I added RFC. >>> >>> I appreciate comments from people who are familiar >>> with toolchains (binutils, llvm). >>> >>> If this change is not safe, >>> we can move this check to Kconfig at least. >> >> Hi Masahiro, >> >> As Fangrui pointed out, there are two outstanding issues with x32 with >> LLVM=1, both seemingly related to LLVM=1. > > Is this still a problem for Clang built Linux? > > > >> https://github.com/ClangBuiltLinux/linux/issues/514 > > I am not tracking the status. > What was the conclusion? This appears to no longer be reproducible so I closed it. >> https://github.com/ClangBuiltLinux/linux/issues/1141 > > > This got marked "unreproducible" I just had a look at this and it is still reproducible (see the bug for details). >> Additionally, there appears to be one from Arnd as well but that one has >> received no triage yet. >> >> https://github.com/ClangBuiltLinux/linux/issues/1205 > > Same as well. Yeah, I cannot reproduce this. It seems like a Kconfig test would still be best for the issue above, if it is not too much to maintain. Cheers, Nathan