From: Allison Henderson <allison.henderson@oracle.com>
To: "david@fromorbit.com" <david@fromorbit.com>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 14/42] xfs: introduce xfs_for_each_perag_wrap()
Date: Mon, 23 Jan 2023 05:41:09 +0000 [thread overview]
Message-ID: <1a182bbf59367d391ead1069a2299853467bb882.camel@oracle.com> (raw)
In-Reply-To: <20230118224505.1964941-15-david@fromorbit.com>
On Thu, 2023-01-19 at 09:44 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> In several places we iterate every AG from a specific start agno and
> wrap back to the first AG when we reach the end of the filesystem to
> continue searching. We don't have a primitive for this iteration
> yet, so add one for conversion of these algorithms to per-ag based
> iteration.
>
> The filestream AG select code is a mess, and this initially makes it
> worse. The per-ag selection needs to be driven completely into the
> filestream code to clean this up and it will be done in a future
> patch that makes the filestream allocator use active per-ag
> references correctly.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/libxfs/xfs_ag.h | 45 +++++++++++++++++++++-
> fs/xfs/libxfs/xfs_bmap.c | 76 ++++++++++++++++++++++--------------
> --
> fs/xfs/libxfs/xfs_ialloc.c | 32 ++++++++--------
> 3 files changed, 104 insertions(+), 49 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_ag.h b/fs/xfs/libxfs/xfs_ag.h
> index 187d30d9bb13..8f43b91d4cf3 100644
> --- a/fs/xfs/libxfs/xfs_ag.h
> +++ b/fs/xfs/libxfs/xfs_ag.h
> @@ -237,7 +237,6 @@ xfs_perag_next(
> #define for_each_perag_from(mp, agno, pag) \
> for_each_perag_range((mp), (agno), (mp)->m_sb.sb_agcount - 1,
> (pag))
>
> -
> #define for_each_perag(mp, agno, pag) \
> (agno) = 0; \
> for_each_perag_from((mp), (agno), (pag))
> @@ -249,6 +248,50 @@ xfs_perag_next(
> xfs_perag_rele(pag), \
> (pag) = xfs_perag_grab_tag((mp), (agno), (tag)))
>
> +static inline struct xfs_perag *
> +xfs_perag_next_wrap(
> + struct xfs_perag *pag,
> + xfs_agnumber_t *agno,
> + xfs_agnumber_t stop_agno,
> + xfs_agnumber_t wrap_agno)
> +{
> + struct xfs_mount *mp = pag->pag_mount;
> +
> + *agno = pag->pag_agno + 1;
> + xfs_perag_rele(pag);
> + while (*agno != stop_agno) {
> + if (*agno >= wrap_agno)
> + *agno = 0;
> + if (*agno == stop_agno)
> + break;
> +
> + pag = xfs_perag_grab(mp, *agno);
> + if (pag)
> + return pag;
> + (*agno)++;
> + }
> + return NULL;
> +}
> +
> +/*
> + * Iterate all AGs from start_agno through wrap_agno, then 0 through
> + * (start_agno - 1).
> + */
> +#define for_each_perag_wrap_at(mp, start_agno, wrap_agno, agno, pag)
> \
> + for ((agno) = (start_agno), (pag) = xfs_perag_grab((mp),
> (agno)); \
> + (pag) != NULL; \
> + (pag) = xfs_perag_next_wrap((pag), &(agno),
> (start_agno), \
> + (wrap_agno)))
> +
> +/*
> + * Iterate all AGs from start_agno through to the end of the
> filesystem, then 0
> + * through (start_agno - 1).
> + */
> +#define for_each_perag_wrap(mp, start_agno, agno, pag) \
> + for_each_perag_wrap_at((mp), (start_agno), (mp)-
> >m_sb.sb_agcount, \
> + (agno), (pag))
> +
> +
> struct aghdr_init_data {
> /* per ag data */
> xfs_agblock_t agno; /* ag to init */
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index 6aad0ea5e606..e5519abbfa0d 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -3136,17 +3136,14 @@ xfs_bmap_adjacent(
>
> static int
> xfs_bmap_longest_free_extent(
> + struct xfs_perag *pag,
> struct xfs_trans *tp,
> - xfs_agnumber_t ag,
> xfs_extlen_t *blen,
> int *notinit)
> {
> - struct xfs_mount *mp = tp->t_mountp;
> - struct xfs_perag *pag;
> xfs_extlen_t longest;
> int error = 0;
>
> - pag = xfs_perag_get(mp, ag);
> if (!xfs_perag_initialised_agf(pag)) {
> error = xfs_alloc_read_agf(pag, tp,
> XFS_ALLOC_FLAG_TRYLOCK,
> NULL);
> @@ -3156,19 +3153,17 @@ xfs_bmap_longest_free_extent(
> *notinit = 1;
> error = 0;
> }
> - goto out;
> + return error;
> }
> }
>
> longest = xfs_alloc_longest_free_extent(pag,
> - xfs_alloc_min_freelist(mp, pag),
> + xfs_alloc_min_freelist(pag-
> >pag_mount, pag),
> xfs_ag_resv_needed(pag,
> XFS_AG_RESV_NONE));
> if (*blen < longest)
> *blen = longest;
>
> -out:
> - xfs_perag_put(pag);
> - return error;
> + return 0;
> }
>
> static void
> @@ -3206,9 +3201,10 @@ xfs_bmap_btalloc_select_lengths(
> xfs_extlen_t *blen)
> {
> struct xfs_mount *mp = ap->ip->i_mount;
> - xfs_agnumber_t ag, startag;
> + struct xfs_perag *pag;
> + xfs_agnumber_t agno, startag;
> int notinit = 0;
> - int error;
> + int error = 0;
>
> args->type = XFS_ALLOCTYPE_START_BNO;
> if (ap->tp->t_flags & XFS_TRANS_LOWMODE) {
> @@ -3218,21 +3214,21 @@ xfs_bmap_btalloc_select_lengths(
> }
>
> args->total = ap->total;
> - startag = ag = XFS_FSB_TO_AGNO(mp, args->fsbno);
> + startag = XFS_FSB_TO_AGNO(mp, args->fsbno);
> if (startag == NULLAGNUMBER)
> - startag = ag = 0;
> + startag = 0;
>
> - while (*blen < args->maxlen) {
> - error = xfs_bmap_longest_free_extent(args->tp, ag,
> blen,
> + *blen = 0;
> + for_each_perag_wrap(mp, startag, agno, pag) {
> + error = xfs_bmap_longest_free_extent(pag, args->tp,
> blen,
> ¬init);
> if (error)
> - return error;
> -
> - if (++ag == mp->m_sb.sb_agcount)
> - ag = 0;
> - if (ag == startag)
> + break;
> + if (*blen >= args->maxlen)
> break;
> }
> + if (pag)
> + xfs_perag_rele(pag);
>
> xfs_bmap_select_minlen(ap, args, blen, notinit);
> return 0;
Hmm, did you want to return error here? Since now we only break on
error in the loop body above?
Otherwise looks good.
Allison
> @@ -3245,7 +3241,8 @@ xfs_bmap_btalloc_filestreams(
> xfs_extlen_t *blen)
> {
> struct xfs_mount *mp = ap->ip->i_mount;
> - xfs_agnumber_t ag;
> + struct xfs_perag *pag;
> + xfs_agnumber_t start_agno;
> int notinit = 0;
> int error;
>
> @@ -3259,33 +3256,50 @@ xfs_bmap_btalloc_filestreams(
> args->type = XFS_ALLOCTYPE_NEAR_BNO;
> args->total = ap->total;
>
> - ag = XFS_FSB_TO_AGNO(mp, args->fsbno);
> - if (ag == NULLAGNUMBER)
> - ag = 0;
> + start_agno = XFS_FSB_TO_AGNO(mp, args->fsbno);
> + if (start_agno == NULLAGNUMBER)
> + start_agno = 0;
>
> - error = xfs_bmap_longest_free_extent(args->tp, ag, blen,
> ¬init);
> - if (error)
> - return error;
> + pag = xfs_perag_grab(mp, start_agno);
> + if (pag) {
> + error = xfs_bmap_longest_free_extent(pag, args->tp,
> blen,
> + ¬init);
> + xfs_perag_rele(pag);
> + if (error)
> + return error;
> + }
>
> if (*blen < args->maxlen) {
> - error = xfs_filestream_new_ag(ap, &ag);
> + xfs_agnumber_t agno = start_agno;
> +
> + error = xfs_filestream_new_ag(ap, &agno);
> if (error)
> return error;
> + if (agno == NULLAGNUMBER)
> + goto out_select;
>
> - error = xfs_bmap_longest_free_extent(args->tp, ag,
> blen,
> - ¬init);
> + pag = xfs_perag_grab(mp, agno);
> + if (!pag)
> + goto out_select;
> +
> + error = xfs_bmap_longest_free_extent(pag, args->tp,
> + blen, ¬init);
> + xfs_perag_rele(pag);
> if (error)
> return error;
>
> + start_agno = agno;
> +
> }
>
> +out_select:
> xfs_bmap_select_minlen(ap, args, blen, notinit);
>
> /*
> * Set the failure fallback case to look in the selected AG
> as stream
> * may have moved.
> */
> - ap->blkno = args->fsbno = XFS_AGB_TO_FSB(mp, ag, 0);
> + ap->blkno = args->fsbno = XFS_AGB_TO_FSB(mp, start_agno, 0);
> return 0;
> }
>
> diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c
> index 2a323ffa5ba9..50fef3f5af51 100644
> --- a/fs/xfs/libxfs/xfs_ialloc.c
> +++ b/fs/xfs/libxfs/xfs_ialloc.c
> @@ -1725,7 +1725,7 @@ xfs_dialloc(
> bool ok_alloc = true;
> bool low_space = false;
> int flags;
> - xfs_ino_t ino;
> + xfs_ino_t ino = NULLFSINO;
>
> /*
> * Directories, symlinks, and regular files frequently
> allocate at least
> @@ -1773,39 +1773,37 @@ xfs_dialloc(
> * or in which we can allocate some inodes. Iterate through
> the
> * allocation groups upward, wrapping at the end.
> */
> - agno = start_agno;
> flags = XFS_ALLOC_FLAG_TRYLOCK;
> - for (;;) {
> - pag = xfs_perag_grab(mp, agno);
> +retry:
> + for_each_perag_wrap_at(mp, start_agno, mp->m_maxagi, agno,
> pag) {
> if (xfs_dialloc_good_ag(pag, *tpp, mode, flags,
> ok_alloc)) {
> error = xfs_dialloc_try_ag(pag, tpp, parent,
> &ino, ok_alloc);
> if (error != -EAGAIN)
> break;
> + error = 0;
> }
>
> if (xfs_is_shutdown(mp)) {
> error = -EFSCORRUPTED;
> break;
> }
> - if (++agno == mp->m_maxagi)
> - agno = 0;
> - if (agno == start_agno) {
> - if (!flags) {
> - error = -ENOSPC;
> - break;
> - }
> + }
> + if (pag)
> + xfs_perag_rele(pag);
> + if (error)
> + return error;
> + if (ino == NULLFSINO) {
> + if (flags) {
> flags = 0;
> if (low_space)
> ok_alloc = true;
> + goto retry;
> }
> - xfs_perag_rele(pag);
> + return -ENOSPC;
> }
> -
> - if (!error)
> - *new_ino = ino;
> - xfs_perag_rele(pag);
> - return error;
> + *new_ino = ino;
> + return 0;
> }
>
> /*
next prev parent reply other threads:[~2023-01-23 5:41 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 22:44 [PATCH 00/42] xfs: per-ag centric allocation alogrithms Dave Chinner
2023-01-18 22:44 ` [PATCH 01/42] xfs: fix low space alloc deadlock Dave Chinner
2023-01-19 16:39 ` Allison Henderson
2024-12-23 9:43 ` luminosity1999
2023-01-18 22:44 ` [PATCH 02/42] xfs: prefer free inodes at ENOSPC over chunk allocation Dave Chinner
2023-01-19 19:08 ` Allison Henderson
2023-01-18 22:44 ` [PATCH 03/42] xfs: block reservation too large for minleft allocation Dave Chinner
2023-01-19 20:38 ` Allison Henderson
2023-01-18 22:44 ` [PATCH 04/42] xfs: drop firstblock constraints from allocation setup Dave Chinner
2023-01-19 22:03 ` Allison Henderson
2023-01-18 22:44 ` [PATCH 05/42] xfs: t_firstblock is tracking AGs not blocks Dave Chinner
2023-01-19 22:12 ` Allison Henderson
2023-01-18 22:44 ` [PATCH 06/42] xfs: don't assert fail on transaction cancel with deferred ops Dave Chinner
2023-01-19 22:18 ` Allison Henderson
2023-01-18 22:44 ` [PATCH 07/42] xfs: active perag reference counting Dave Chinner
2023-01-21 5:16 ` Allison Henderson
2023-02-01 19:08 ` Darrick J. Wong
2023-02-06 22:56 ` Dave Chinner
2023-01-18 22:44 ` [PATCH 08/42] xfs: rework the perag trace points to be perag centric Dave Chinner
2023-01-21 5:16 ` Allison Henderson
2023-01-18 22:44 ` [PATCH 09/42] xfs: convert xfs_imap() to take a perag Dave Chinner
2023-02-01 19:10 ` Darrick J. Wong
2023-01-18 22:44 ` [PATCH 10/42] xfs: use active perag references for inode allocation Dave Chinner
2023-01-22 6:48 ` Allison Henderson
2023-01-18 22:44 ` [PATCH 11/42] xfs: inobt can use perags in many more places than it does Dave Chinner
2023-01-22 6:48 ` Allison Henderson
2023-01-18 22:44 ` [PATCH 12/42] xfs: convert xfs_ialloc_next_ag() to an atomic Dave Chinner
2023-01-22 7:03 ` Allison Henderson
2023-01-18 22:44 ` [PATCH 13/42] xfs: perags need atomic operational state Dave Chinner
2023-01-23 4:04 ` Allison Henderson
2023-01-18 22:44 ` [PATCH 14/42] xfs: introduce xfs_for_each_perag_wrap() Dave Chinner
2023-01-23 5:41 ` Allison Henderson [this message]
2023-02-06 23:14 ` Dave Chinner
2023-02-01 19:28 ` Darrick J. Wong
2023-01-18 22:44 ` [PATCH 15/42] xfs: rework xfs_alloc_vextent() Dave Chinner
2023-02-01 19:39 ` Darrick J. Wong
2023-01-18 22:44 ` [PATCH 16/42] xfs: factor xfs_alloc_vextent_this_ag() for _iterate_ags() Dave Chinner
2023-01-18 22:44 ` [PATCH 17/42] xfs: combine __xfs_alloc_vextent_this_ag and xfs_alloc_ag_vextent Dave Chinner
2023-02-01 22:25 ` Darrick J. Wong
2023-01-18 22:44 ` [PATCH 18/42] xfs: use xfs_alloc_vextent_this_ag() where appropriate Dave Chinner
2023-01-18 22:44 ` [PATCH 19/42] xfs: factor xfs_bmap_btalloc() Dave Chinner
2023-01-18 22:44 ` [PATCH 20/42] xfs: use xfs_alloc_vextent_first_ag() where appropriate Dave Chinner
2023-02-01 22:43 ` Darrick J. Wong
2023-02-06 23:16 ` Dave Chinner
2023-01-18 22:44 ` [PATCH 21/42] xfs: use xfs_alloc_vextent_start_bno() " Dave Chinner
2023-02-01 22:51 ` Darrick J. Wong
2023-01-18 22:44 ` [PATCH 22/42] xfs: introduce xfs_alloc_vextent_near_bno() Dave Chinner
2023-02-01 22:52 ` Darrick J. Wong
2023-01-18 22:44 ` [PATCH 23/42] xfs: introduce xfs_alloc_vextent_exact_bno() Dave Chinner
2023-02-01 23:00 ` Darrick J. Wong
2023-01-18 22:44 ` [PATCH 24/42] xfs: introduce xfs_alloc_vextent_prepare() Dave Chinner
2023-01-18 22:44 ` [PATCH 25/42] xfs: move allocation accounting to xfs_alloc_vextent_set_fsbno() Dave Chinner
2023-01-18 22:44 ` [PATCH 26/42] xfs: fold xfs_alloc_ag_vextent() into callers Dave Chinner
2023-01-18 22:44 ` [PATCH 27/42] xfs: move the minimum agno checks into xfs_alloc_vextent_check_args Dave Chinner
2023-01-18 22:44 ` [PATCH 28/42] xfs: convert xfs_alloc_vextent_iterate_ags() to use perag walker Dave Chinner
2023-02-01 23:13 ` Darrick J. Wong
2023-01-18 22:44 ` [PATCH 29/42] xfs: convert trim to use for_each_perag_range Dave Chinner
2023-02-01 23:15 ` Darrick J. Wong
2023-02-06 23:19 ` Dave Chinner
2023-01-18 22:44 ` [PATCH 30/42] xfs: factor out filestreams from xfs_bmap_btalloc_nullfb Dave Chinner
2023-01-18 22:44 ` [PATCH 31/42] xfs: get rid of notinit from xfs_bmap_longest_free_extent Dave Chinner
2023-01-18 22:44 ` [PATCH 32/42] xfs: use xfs_bmap_longest_free_extent() in filestreams Dave Chinner
2023-01-18 22:44 ` [PATCH 33/42] xfs: move xfs_bmap_btalloc_filestreams() to xfs_filestreams.c Dave Chinner
2023-01-18 22:44 ` [PATCH 34/42] xfs: merge filestream AG lookup into xfs_filestream_select_ag() Dave Chinner
2023-01-18 22:44 ` [PATCH 35/42] xfs: merge new filestream AG selection " Dave Chinner
2023-01-18 22:44 ` [PATCH 36/42] xfs: remove xfs_filestream_select_ag() longest extent check Dave Chinner
2023-01-18 22:45 ` [PATCH 37/42] xfs: factor out MRU hit case in xfs_filestream_select_ag Dave Chinner
2023-01-18 22:45 ` [PATCH 38/42] xfs: track an active perag reference in filestreams Dave Chinner
2023-01-18 22:45 ` [PATCH 39/42] xfs: use for_each_perag_wrap in xfs_filestream_pick_ag Dave Chinner
2023-01-18 22:45 ` [PATCH 40/42] xfs: pass perag to filestreams tracing Dave Chinner
2023-01-18 22:45 ` [PATCH 41/42] xfs: return a referenced perag from filestreams allocator Dave Chinner
2023-02-02 0:01 ` Darrick J. Wong
2023-02-06 23:22 ` Dave Chinner
2023-01-18 22:45 ` [PATCH 42/42] xfs: refactor the filestreams allocator pick functions Dave Chinner
2023-02-02 0:08 ` Darrick J. Wong
2023-02-06 23:26 ` Dave Chinner
2023-02-02 0:14 ` [PATCH 00/42] xfs: per-ag centric allocation alogrithms Darrick J. Wong
2023-02-06 23:13 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2023-02-09 22:17 [PATCH v3 " Dave Chinner
2023-02-09 22:17 ` [PATCH 14/42] xfs: introduce xfs_for_each_perag_wrap() Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a182bbf59367d391ead1069a2299853467bb882.camel@oracle.com \
--to=allison.henderson@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox