Re: [PATCH 5/7] xfs: rename the bt_bdev_* buftarg fields

[John Garry <john.g.garry@oracle.com>]

On 17/06/2025 11:52, Christoph Hellwig wrote:
> The extra bdev_ is weird, so drop it.  The maximum size is based on the
> bdev hardware limits, so add a hw_ component instead.

but the min is also based on hw limits, no?

I also note that we have request queue limits atomic_write_unit_max and 
atomic_write_hw_unit_max

and bt_awu_max_hw is written with request queue limit atomic_write_unit_max

But I don't think that this will cause confusion.

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   fs/xfs/xfs_buf.c   | 4 ++--
>   fs/xfs/xfs_buf.h   | 4 ++--
>   fs/xfs/xfs_file.c  | 2 +-
>   fs/xfs/xfs_inode.h | 2 +-
>   fs/xfs/xfs_iomap.c | 2 +-
>   fs/xfs/xfs_iops.c  | 2 +-
>   fs/xfs/xfs_mount.c | 2 +-
>   7 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index 0f15837724e7..abd66665fb8c 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -1712,8 +1712,8 @@ xfs_configure_buftarg_atomic_writes(
>   		max_bytes = 0;
>   	}
>   
> -	btp->bt_bdev_awu_min = min_bytes;
> -	btp->bt_bdev_awu_max = max_bytes;
> +	btp->bt_awu_min = min_bytes;
> +	btp->bt_awu_max_hw = max_bytes;>   }
>