public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: Martin Steigerwald <Martin@lichtvoll.de>
Cc: linux-xfs@oss.sgi.com
Subject: Re: XFS and write barrier
Date: Wed, 19 Jul 2006 05:21:35 +1000	[thread overview]
Message-ID: <20060718192135.GV15160733@melbourne.sgi.com> (raw)
In-Reply-To: <200607182027.49648.Martin@lichtvoll.de>

On Tue, Jul 18, 2006 at 08:27:48PM +0200, Martin Steigerwald wrote:
> Am Dienstag 18 Juli 2006 19:04 schrieb David Chinner:
> 
> > > "Journalling filesystems need write barrier" isn't really accurate.
> > > They can make good use of write barrier if it is supported, and where
> > > it isn't supported, they should use blkdev_issue_flush in combination
> > > with regular submit/wait.
> >
> > blkdev_issue_flush() causes a write cache flush - just like a
> > barrier typically causes a write cache flush up to the I/O with the
> > barrier in it.  Both of these mechanisms provide the same thing - an
> > I/O barrier that enforces ordering of I/Os to disk.
> 
> Hello David,
> 
> well now it gets interesting. If both provide the same thing, whats the 
> difference?

A WRITE_BARRIER I/O can be optimised by smart drivers, protocols and hardware
to minimise the adverse effects of the barrier, whereas a cache flush
is a brute force cache cleaning mechanism that cannot be optimised....

> > Given that filesystems already indicate to the block layer when they
> > want a barrier, wouldn't it be better to get the block layer to issue
> > this cache flush if the underlying device doesn't support barriers
> > and it receives a barrier request?
> 
> Does a device need to support more than this cache flush in order to 
> support barriers? Up to know I thought that when a device supports cache 
> flushes the kernel can provide barrier functinality for it.

Not necessarily as different device/protocol commands are used.

> I see in boot output that my notebook harddisk supports cache flushes. But 
> not in dmesg nor in syslog. I don't know yet how to actually determine 
> whether barrier functionality is really usable on a certain system. 

My test is to mount an XFS filesystem using barriers on the device and
look at the syslog message. ;)

> > FWIW, Only XFS and Reiser3 use this function, and only then when
> > issuing a fsync when barriers are disabled to make sure a common
> > test (fsync then power cycle) doesn't result in data loss...
> 
> So will XFS be safe even without write barriers?

XFS is only safe when you have:

	a) no write caching on the drive (barrier or nobarrier)
	b) non-volatile write caching on the drive (barrier or nobarrier)
	c) volatile write caching and barriers supported and enabled

The same conditions hold true for any filesystem that requires I/O ordering
guarantees to maintain filesystem consistency...

> What will it do when it 
> cannot do write barriers but write barriers are requested by the user or 
> the inbuilt default setting of the filesystem?  Will it work unsafely or 
> will mount readonly or disable write caches in that case?

XFS will log a warning to the syslog and dmesg saying write barriers are
disabled and continue onwards without barriers.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

  reply	other threads:[~2006-07-18 19:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-15 10:48 XFS and write barrier Martin Steigerwald
2006-07-15 19:28 ` Chris Wedgwood
2006-07-16  9:53   ` Martin Steigerwald
2006-07-17  0:43     ` Chris Wedgwood
2006-07-17  1:24       ` Chris Wedgwood
2006-07-16 17:32 ` Federico Sevilla III
2006-07-18  7:31   ` Nathan Scott
2006-07-18  8:58     ` Neil Brown
2006-07-18 17:04       ` David Chinner
2006-07-18 18:27         ` Martin Steigerwald
2006-07-18 19:21           ` David Chinner [this message]
2006-07-20 10:34             ` Martin Steigerwald
2006-07-22  9:31             ` Martin Steigerwald
2006-07-22 10:36               ` Stefan Smietanowski
2006-07-18 23:41         ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060718192135.GV15160733@melbourne.sgi.com \
    --to=dgc@sgi.com \
    --cc=Martin@lichtvoll.de \
    --cc=linux-xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox