From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: with ECARTIS (v1.0.0; list xfs); Tue, 18 Jul 2006 15:28:34 -0700 (PDT) Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id k6IMQpDW011252 for ; Tue, 18 Jul 2006 15:27:03 -0700 Date: Wed, 19 Jul 2006 08:24:59 +1000 From: Nathan Scott Subject: Re: [patch 01/45] XFS: corruption fix Message-ID: <20060719082458.A1935136@wobbly.melbourne.sgi.com> References: <20060717160652.408007000@blue.kroah.org> <20060717162518.GB4829@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ; from jengelh@linux01.gwdg.de on Tue, Jul 18, 2006 at 03:27:37PM +0200 Sender: xfs-bounce@oss.sgi.com Errors-To: xfs-bounce@oss.sgi.com List-Id: xfs To: Jan Engelhardt Cc: Greg KH , linux-kernel@vger.kernel.org, stable@kernel.org, Justin Forbes , Zwane Mwaikambo , Theodore Ts'o , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk, Mandy Kirkconnell , Chris Wright , xfs@oss.sgi.com On Tue, Jul 18, 2006 at 03:27:37PM +0200, Jan Engelhardt wrote: > > > >Fix nused counter. It's currently getting set to -1 rather than getting > >decremented by 1. Since nused never reaches 0, the "if (!free->hdr.nused)" > >check in xfs_dir2_leafn_remove() fails every time and xfs_dir2_shrink_inode() > >doesn't get called when it should. This causes extra blocks to be left on > >an empty directory and the directory in unable to be converted back to > >inline extent mode. > > > Is there a utility to fix such directories or will they autoshrink once the fs > is run with a 2.6.17.7? An xfs_repair is required. There is a remaining issue with repair where it cannot resolve some particular types of directory trashing, but for the most part I believe xfs_repair will resolve this (please report if not). We're working on improving the way xfs_repair deals with dir2 corruption atm, so this remaining problem (that funky dir2 offset problem, iow) I expect will shortly be resolved. cheers. -- Nathan